Add WikiRedirectsController with destroy action

Author: kfischer-okarin

app/controllers/wiki_redirects_controller.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+# Redmine - project management software
+# Copyright (C) 2006-2020  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+class WikiRedirectsController < ApplicationController
+  before_action :find_wiki_redirect, :authorize
+
+  def destroy
+    @wiki_redirect.destroy
+  end
+
+  private
+
+  def find_wiki_redirect
+    @project = Project.find(params[:project_id])
+    page = Wiki.find_page(params[:wiki_page_id], project: @project)
+    @wiki_redirect= WikiRedirect.where(redirects_to: page.title).find(params[:id])
+    render_404 unless @wiki_redirect
+  rescue ActiveRecord::RecordNotFound
+    render_404
+  end
+end

config/routes.rb

@@ -191,6 +191,7 @@
 
     match 'wiki/index', :controller => 'wiki', :action => 'index', :via => :get
     resources :wiki, :except => [:index, :create], :as => 'wiki_page' do
+      resources :redirects, controller: 'wiki_redirects', only: :destroy
       member do
         get 'rename'
         post 'rename'

lib/redmine/preparation.rb

@@ -121,7 +121,7 @@ def self.prepare
           map.permission :view_wiki_edits, {:wiki => [:history, :diff, :annotate]}, :read => true
           map.permission :export_wiki_pages, {:wiki => [:export]}, :read => true
           map.permission :edit_wiki_pages, :wiki => [:new, :edit, :update, :preview, :add_attachment], :attachments => :upload
-          map.permission :rename_wiki_pages, {:wiki => :rename}, :require => :member
+          map.permission :rename_wiki_pages, {:wiki => :rename, :wiki_redirects => :destroy}, :require => :member
           map.permission :delete_wiki_pages, {:wiki => [:destroy, :destroy_version]}, :require => :member
           map.permission :delete_wiki_pages_attachments, {}
           map.permission :view_wiki_page_watchers, {}, :read => true

test/functional/wiki_redirects_controller_test.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+# Redmine - project management software
+# Copyright (C) 2006-2020  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../test_helper', __FILE__)
+
+class WikiRedirectsControllerTest < Redmine::ControllerTest
+  fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
+           :enabled_modules, :wikis, :wiki_pages, :wiki_contents,
+           :wiki_content_versions, :attachments,
+           :issues, :issue_statuses, :trackers
+
+  def setup
+    User.current = nil
+    @request.session[:user_id] = 1
+  end
+
+  def test_destroy
+    wiki_page = WikiPage.find(2)
+    old_title = wiki_page.title
+    wiki_page.title = 'Test'
+    wiki_page.save
+
+    wiki_redirect = WikiRedirect.find_by(title: old_title, redirects_to: 'Test')
+
+    delete :destroy, params: {id: wiki_redirect.id, project_id: wiki_page.wiki.project_id, wiki_page_id: 'Test'}
+
+    assert_response :success
+    assert_not WikiRedirect.exists?(id: wiki_redirect.id)
+  end
+
+  def test_destroy_without_permission
+    @request.session[:user_id] = User.generate!.id
+
+    wiki_page = WikiPage.find(2)
+    old_title = wiki_page.title
+    wiki_page.title = 'Test'
+    wiki_page.save
+
+    wiki_redirect = WikiRedirect.find_by(title: old_title, redirects_to: 'Test')
+
+    delete :destroy, params: {id: wiki_redirect.id, project_id: wiki_page.wiki.project_id, wiki_page_id: 'Test'}
+
+    assert_response :forbidden
+    assert WikiRedirect.exists?(id: wiki_redirect.id)
+  end
+
+  def test_invalid_redirect_should_respond_with_404
+    wiki_page = WikiPage.find(1)
+    old_title = wiki_page.title
+    wiki_page.title = 'New_Title'
+    wiki_page.save
+
+    other_wiki_page = WikiPage.find(2)
+    other_wiki_page.title = 'Other_New_Title'
+    other_wiki_page.save
+
+    wiki_redirect = WikiRedirect.find_by(title: old_title, redirects_to: 'New_Title')
+
+    delete :destroy, params: {id: wiki_redirect.id, project_id: other_wiki_page.wiki.project_id, wiki_page_id: 'Other_New_Title'}
+
+    assert_response :not_found
+    assert WikiRedirect.exists?(id: wiki_redirect.id)
+  end
+end