Skip to content

Commit 5c1c07b

Browse files
fkdkentRedmine Patch Meetup
authored andcommitted
Implement
1 parent 42555e5 commit 5c1c07b

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

app/models/issue.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -729,6 +729,8 @@ def workflow_rule_by_attribute(user=nil)
729729
def done_ratio
730730
if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
731731
status.default_done_ratio
732+
elsif Issue.use_issue_field_and_closed_status_for_done_ratio? && status && status.is_closed?
733+
100
732734
else
733735
read_attribute(:done_ratio)
734736
end
@@ -742,6 +744,10 @@ def self.use_field_for_done_ratio?
742744
Setting.issue_done_ratio == 'issue_field'
743745
end
744746

747+
def self.use_issue_field_and_closed_status_for_done_ratio?
748+
Setting.issue_done_ratio == 'issue_field_and_closed_status'
749+
end
750+
745751
def validate_issue
746752
if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
747753
errors.add :due_date, :greater_than_start_date
@@ -848,6 +854,8 @@ def validate_custom_field_values
848854
def update_done_ratio_from_issue_status
849855
if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
850856
self.done_ratio = status.default_done_ratio
857+
elsif Issue.use_issue_field_and_closed_status_for_done_ratio? && status && status.is_closed?
858+
self.done_ratio = 100
851859
end
852860
end
853861

0 commit comments

Comments
 (0)