Skip to content

Commit 5e3d403

Browse files
fkdkentRedmine Patch Meetup
authored andcommitted
Implement
1 parent c4b5114 commit 5e3d403

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

app/models/issue.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -735,6 +735,8 @@ def workflow_rule_by_attribute(user=nil)
735735
def done_ratio
736736
if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
737737
status.default_done_ratio
738+
elsif Issue.use_issue_field_and_closed_status_for_done_ratio? && status && status.is_closed?
739+
100
738740
else
739741
read_attribute(:done_ratio)
740742
end
@@ -748,6 +750,10 @@ def self.use_field_for_done_ratio?
748750
Setting.issue_done_ratio == 'issue_field'
749751
end
750752

753+
def self.use_issue_field_and_closed_status_for_done_ratio?
754+
Setting.issue_done_ratio == 'issue_field_and_closed_status'
755+
end
756+
751757
def validate_issue
752758
if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
753759
errors.add :due_date, :greater_than_start_date
@@ -860,6 +866,8 @@ def validate_custom_field_values
860866
def update_done_ratio_from_issue_status
861867
if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
862868
self.done_ratio = status.default_done_ratio
869+
elsif Issue.use_issue_field_and_closed_status_for_done_ratio? && status && status.is_closed?
870+
self.done_ratio = 100
863871
end
864872
end
865873

0 commit comments

Comments
 (0)