Roadmap tab is missing if there are only inherited from parent project versions (#34983).

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20921 e93f8b46-1217-0410-a6f0-8f06a7374b81

Author: vividtone

lib/redmine.rb

@@ -367,10 +367,10 @@
     :param => :project_id,
     :if =>
       Proc.new do |p|
-        if Setting.display_subprojects_issues?
-          p.rolled_up_versions.any?
+        if p.shared_versions.any?
+          true
         else
-          p.shared_versions.any?
+          Setting.display_subprojects_issues? && p.rolled_up_versions.any?
         end
       end
   )

test/integration/lib/redmine/menu_manager_test.rb

@@ -147,4 +147,21 @@ def test_project_menu_should_show_roadmap_if_subprojects_have_versions
       assert_select '#main-menu a.roadmap', 0
     end
   end
+
+  def test_project_menu_should_show_roadmap_if_project_has_shared_version
+    Version.delete_all
+    project = Project.generate!(:parent_id => 2)
+
+    Version.generate!(project_id: 2, sharing: 'tree')
+
+    with_settings :display_subprojects_issues => '1' do
+      get "/projects/#{project.id}"
+      assert_select '#main-menu a.roadmap'
+    end
+
+    with_settings :display_subprojects_issues => '0' do
+      get "/projects/#{project.id}"
+      assert_select '#main-menu a.roadmap'
+    end
+  end
 end