Invalid links to versions with sharing in project tree (#32860).

Patch by Alexander Meindl.


git-svn-id: http://svn.redmine.org/redmine/trunk@20149 e93f8b46-1217-0410-a6f0-8f06a7374b81

Author: vividtone

app/helpers/versions_helper.rb

@@ -31,11 +31,11 @@ def version_filtered_issues_path(version, options = {})
     options = {:fixed_version_id => version, :set_filter => 1}.merge(options)
     project =
       case version.sharing
-      when 'hierarchy', 'tree'
-        if version.project && version.project.root.visible?
+      when 'tree'
+        if version.project && version.project.root.visible? && User.current.allowed_to?(:view_issues, version.project.root)
           version.project.root
         else
-          version.project
+          nil
         end
       when 'system'
         nil

test/helpers/version_helper_test.rb

@@ -42,7 +42,7 @@ def test_version_filtered_issues_path_sharing_descendants
   def test_version_filtered_issues_path_sharing_hierarchy
     version = Version.new(:name => 'test', :sharing => 'hierarchy')
     version.project = Project.find(5)
-    assert_match '/projects/ecookbook/issues?', version_filtered_issues_path(version)
+    assert_match '/projects/private-child/issues?', version_filtered_issues_path(version)
   end
 
   def test_version_filtered_issues_path_sharing_tree
@@ -51,6 +51,14 @@ def test_version_filtered_issues_path_sharing_tree
     assert_match '/projects/ecookbook/issues?', version_filtered_issues_path(version)
   end
 
+  def test_version_filtered_issues_path_sharing_tree_without_permission_to_root_project
+    EnabledModule.where("name = 'issue_tracking' AND project_id = 1").delete_all
+    version = Version.new(:name => 'test', :sharing => 'tree')
+    version.project = Project.find(5)
+    assert_no_match '/projects/ecookbook/issues?', version_filtered_issues_path(version)
+    assert_match '/issues?', version_filtered_issues_path(version)
+  end
+
   def test_version_filtered_issues_path_sharing_system
     version = Version.new(:name => 'test', :sharing => 'system')
     version.project = Project.find(5)