第23回 viewに実装していた処理をhelperに切り出した

Author: juno-nishizaki

app/helpers/mailer_helper.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+# Redmine - project management software
+# Copyright (C) 2006-2022  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+module MailerHelper
+  def show_recipients(recipients)
+    recipients.take(Setting.show_recipients_limit.to_i).map(&:name).join(', ') + (recipients.size > Setting.show_recipients_limit.to_i ? '...' : '')
+  end
+end

app/models/mailer.rb

@@ -24,6 +24,7 @@ class Mailer < ActionMailer::Base
   helper :application
   helper :issues
   helper :custom_fields
+  helper :mailer
 
   include Redmine::I18n
   include Roadie::Rails::Automatic

app/views/layouts/mailer.html.erb

@@ -86,7 +86,7 @@ table, td, th {
 <% if Setting.show_recipients_in_mail_footer? && @recipients.present? %>
 <span class="recipients">
   <%= l(:text_sent_email_to_recipients) %><br>
-  <%= @recipients.take(Setting.show_recipients_limit.to_i).map(&:name).join(', ') %><%= '...' if @recipients.size > Setting.show_recipients_limit.to_i %>
+  <%= show_recipients @recipients %>
 </span>
 <% end %>
 </body>

app/views/layouts/mailer.text.erb

@@ -9,5 +9,5 @@
 <% if Setting.show_recipients_in_mail_footer? && @recipients.present? %>
 
 <%= l(:text_sent_email_to_recipients) %>
-<%= @recipients.take(Setting.show_recipients_limit.to_i).map(&:name).join(', ') %><%= '...' if @recipients.size > Setting.show_recipients_limit.to_i %>
+<%= show_recipients @recipients %>
 <% end -%>