Skip to content

Commit c3edc23

Browse files
fkdkentRedmine Patch Meetup
authored andcommitted
Use update
1 parent fb88471 commit c3edc23

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

test/unit/issue_test.rb

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2918,24 +2918,21 @@ def test_saving_twice_should_not_duplicate_journal_details
29182918

29192919
with_settings :issue_done_ratio => 'issue_field' do
29202920
issue = Issue.generate!(:status_id => 1, :done_ratio => 30)
2921-
issue.status = closed_status
2922-
issue.save!
2921+
issue.update!(:status => closed_status)
29232922

29242923
assert_equal 30, issue.read_attribute(:done_ratio)
29252924
end
29262925

29272926
with_settings :issue_done_ratio => 'issue_status' do
29282927
issue = Issue.generate!(:status_id => 1, :done_ratio => 30)
2929-
issue.status = closed_status
2930-
issue.save!
2928+
issue.update!(:status => closed_status)
29312929

29322930
assert_equal 90, issue.read_attribute(:done_ratio)
29332931
end
29342932

29352933
with_settings :issue_done_ratio => 'issue_field_and_closed_status' do
29362934
issue = Issue.generate!(:status_id => 1, :done_ratio => 30)
2937-
issue.status = closed_status
2938-
issue.save!
2935+
issue.update!(:status => closed_status)
29392936

29402937
assert_equal 100, issue.read_attribute(:done_ratio)
29412938
end

0 commit comments

Comments
 (0)