Skip to content

Commit ccf9515

Browse files
committed
Encapsulated few important variables
1 parent c62340c commit ccf9515

File tree

4 files changed

+36
-20
lines changed

4 files changed

+36
-20
lines changed

src/com/redomar/game/Game.java

Lines changed: 31 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ public class Game extends Canvas implements Runnable {
4242
private int[] colours = new int[6 * 6 * 6];
4343

4444
private Screen screen;
45-
public InputHandler input;
46-
public WindowHandler window;
47-
public LevelHandler level;
48-
public Player player;
45+
private InputHandler input;
46+
private WindowHandler window;
47+
private LevelHandler level;
48+
private Player player;
4949

5050
private GameClient socketClient;
5151
private GameServer socketServer;
@@ -82,16 +82,16 @@ public void init() {
8282
screen = new Screen(WIDTH, HEIGHT, new SpriteSheet("/sprite_sheet.png"));
8383
input = new InputHandler(this);
8484
window = new WindowHandler(this);
85-
level = new LevelHandler("/levels/water_level.png");
85+
setLevel(new LevelHandler("/levels/water_level.png"));
8686

87-
player = new PlayerMP(level, 100, 100, input,
88-
JOptionPane.showInputDialog(this, "Enter a name"), null, -1);
87+
setPlayer(new PlayerMP(getLevel(), 100, 100, input,
88+
JOptionPane.showInputDialog(this, "Enter a name"), null, -1));
8989

90-
level.addEntity(player);
91-
Packet00Login loginPacket = new Packet00Login(player.getUsername());
90+
getLevel().addEntity(getPlayer());
91+
Packet00Login loginPacket = new Packet00Login(getPlayer().getUsername());
9292

9393
if (socketServer != null) {
94-
socketServer.addConnection((PlayerMP) player, loginPacket);
94+
socketServer.addConnection((PlayerMP) getPlayer(), loginPacket);
9595
}
9696

9797
// socketClient.sendData("ping".getBytes());
@@ -163,7 +163,7 @@ public void run() {
163163

164164
public void tick() {
165165
tickCount++;
166-
level.tick();
166+
getLevel().tick();
167167
}
168168

169169
public void render() {
@@ -173,10 +173,10 @@ public void render() {
173173
return;
174174
}
175175

176-
int xOffset = player.x - (screen.width / 2);
177-
int yOffset = player.y - (screen.height / 2);
176+
int xOffset = getPlayer().x - (screen.width / 2);
177+
int yOffset = getPlayer().y - (screen.height / 2);
178178

179-
level.renderTiles(screen, xOffset, yOffset);
179+
getLevel().renderTiles(screen, xOffset, yOffset);
180180

181181
/*
182182
* for (int x = 0; x < level.width; x++) { int colour = Colours.get(-1,
@@ -185,7 +185,7 @@ public void render() {
185185
* colour, 1); }
186186
*/
187187

188-
level.renderEntities(screen);
188+
getLevel().renderEntities(screen);
189189

190190
for (int y = 0; y < screen.height; y++) {
191191
for (int x = 0; x < screen.width; x++) {
@@ -224,4 +224,20 @@ public void setSocketClient(GameClient socketClient) {
224224
this.socketClient = socketClient;
225225
}
226226

227+
public Player getPlayer() {
228+
return player;
229+
}
230+
231+
public void setPlayer(Player player) {
232+
this.player = player;
233+
}
234+
235+
public LevelHandler getLevel() {
236+
return level;
237+
}
238+
239+
public void setLevel(LevelHandler level) {
240+
this.level = level;
241+
}
242+
227243
}

src/com/redomar/game/WindowHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public void windowClosed(WindowEvent event) {
2626

2727
@Override
2828
public void windowClosing(WindowEvent event) {
29-
Packet01Disconnect packet = new Packet01Disconnect(this.game.player.getUsername());
29+
Packet01Disconnect packet = new Packet01Disconnect(this.game.getPlayer().getUsername());
3030
packet.writeData(this.game.getSocketClient());
3131
}
3232

src/com/redomar/game/net/GameClient.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,16 @@ private void parsePacket(byte[] data, InetAddress address, int port) {
6060
System.out.println("[" + address.getHostAddress() + ":" + port
6161
+ "] " + ((Packet00Login) packet).getUsername()
6262
+ " has joined...");
63-
PlayerMP player = new PlayerMP(game.level, 10, 10,
63+
PlayerMP player = new PlayerMP(game.getLevel(), 10, 10,
6464
((Packet00Login) packet).getUsername(), address, port);
65-
game.level.addEntity(player);
65+
game.getLevel().addEntity(player);
6666
break;
6767
case DISCONNECT:
6868
packet = new Packet01Disconnect(data);
6969
System.out.println("[" + address.getHostAddress() + ":" + port
7070
+ "] " + ((Packet01Disconnect) packet).getUsername()
7171
+ " has disconnected...");
72-
game.level.removeEntity(((Packet01Disconnect)packet).getUsername());
72+
game.getLevel().removeEntity(((Packet01Disconnect)packet).getUsername());
7373
break;
7474
}
7575
}

src/com/redomar/game/net/GameServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ private void parsePacket(byte[] data, InetAddress address, int port) {
6565
System.out.println("[" + address.getHostAddress() + ":" + port
6666
+ "] " + ((Packet00Login) packet).getUsername()
6767
+ " has connected...");
68-
PlayerMP player = new PlayerMP(game.level, 10, 10,
68+
PlayerMP player = new PlayerMP(game.getLevel(), 10, 10,
6969
((Packet00Login) packet).getUsername(), address, port);
7070
this.addConnection(player, (Packet00Login) packet);
7171
break;

0 commit comments

Comments
 (0)