Skip to content

Commit 4feea31

Browse files
josephwoodwardjosephwoodward
committed
fix: govet linting issues
1 parent 065df36 commit 4feea31

File tree

171 files changed

+583
-889
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

171 files changed

+583
-889
lines changed

‎internal/batch/combined_ack_func_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,20 +111,20 @@ func TestCombinedAckErrorSync(t *testing.T) {
111111
})
112112

113113
var derivedFuncs []AckFunc
114-
for i := 0; i < 1000; i++ {
114+
for range 1000 {
115115
derivedFuncs = append(derivedFuncs, combined.Derive())
116116
}
117117

118118
startChan := make(chan struct{})
119119
var wg sync.WaitGroup
120-
for i := 0; i < 10; i++ {
120+
for i := range 10 {
121121
wg.Add(1)
122122
i := i
123123
go func() {
124124
defer wg.Done()
125125
<-startChan
126126

127-
for j := 0; j < 100; j++ {
127+
for j := range 100 {
128128
assert.NoError(t, derivedFuncs[(i*100)+j](t.Context(), nil))
129129
}
130130
}()

‎internal/bloblang/field/expression_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ func TestStaticExpressionOptimization(t *testing.T) {
3434
}
3535

3636
for _, test := range tests {
37-
test := test
3837
t.Run(test.output, func(t *testing.T) {
3938
e := NewExpression(test.input...)
4039
assert.Equal(t, test.output, e.static)
@@ -344,7 +343,6 @@ func TestExpressions(t *testing.T) {
344343
}
345344

346345
for name, test := range tests {
347-
test := test
348346
t.Run(name, func(t *testing.T) {
349347
t.Parallel()
350348

‎internal/bloblang/mapping/executor_test.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,6 @@ func TestAssignments(t *testing.T) {
279279
}
280280

281281
for name, test := range tests {
282-
test := test
283282
t.Run(name, func(t *testing.T) {
284283
msg := message.QuickBatch(nil)
285284
for _, p := range test.input {
@@ -393,7 +392,6 @@ func TestTargets(t *testing.T) {
393392
}
394393

395394
for i, test := range tests {
396-
test := test
397395
t.Run(fmt.Sprintf("%v", i), func(t *testing.T) {
398396
_, targets := test.mapping.QueryTargets(query.TargetsContext{
399397
Maps: map[string]query.Function{},
@@ -494,7 +492,6 @@ func TestExec(t *testing.T) {
494492
}
495493

496494
for name, test := range tests {
497-
test := test
498495
t.Run(name, func(t *testing.T) {
499496
res, err := test.mapping.Exec(query.FunctionContext{
500497
MsgBatch: message.QuickBatch(nil),
@@ -594,7 +591,6 @@ func TestQueries(t *testing.T) {
594591
}
595592

596593
for name, test := range tests {
597-
test := test
598594
t.Run(name, func(t *testing.T) {
599595
msg := message.QuickBatch(nil)
600596
for _, p := range test.input {

‎internal/bloblang/package_test.go‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ root.meow = this.apply("foo")
185185
}
186186

187187
for name, test := range tests {
188-
test := test
189188
t.Run(name, func(t *testing.T) {
190189
m, err := GlobalEnvironment().NewMapping(test.mapping)
191190
require.NoError(t, err)
@@ -234,21 +233,18 @@ func TestMappingParallelExecution(t *testing.T) {
234233
}
235234

236235
for name, test := range tests {
237-
test := test
238236
t.Run(name, func(t *testing.T) {
239237
m, err := GlobalEnvironment().NewMapping(test.mapping)
240238
require.NoError(t, err)
241239

242240
startChan := make(chan struct{})
243241

244242
var wg sync.WaitGroup
245-
for i := 0; i < 10; i++ {
246-
wg.Add(1)
247-
go func() {
248-
defer wg.Done()
243+
for range 10 {
244+
wg.Go(func() {
249245
<-startChan
250246

251-
for j := 0; j < 100; j++ {
247+
for range 100 {
252248
part := message.NewPart(nil)
253249
part.SetStructured(test.input)
254250

@@ -263,7 +259,7 @@ func TestMappingParallelExecution(t *testing.T) {
263259

264260
assert.Equal(t, test.output, res)
265261
}
266-
}()
262+
})
267263
}
268264

269265
close(startChan)

‎internal/bloblang/parser/combinators.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ func UntilTerm(term string) Func[string] {
214214
i := 0
215215
for ; i <= (len(input) - len(termRunes)); i++ {
216216
matched := true
217-
for j := 0; j < len(termRunes); j++ {
217+
for j := range termRunes {
218218
if input[i+j] != termRunes[j] {
219219
matched = false
220220
break

‎internal/bloblang/parser/combinators_test.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,6 @@ func TestOneOfErrors(t *testing.T) {
332332
for name, test := range tests {
333333
childParsers := []Func[any]{}
334334
for _, err := range test.resultErrs {
335-
err := err
336335
childParsers = append(childParsers, func([]rune) Result[any] {
337336
return Result[any]{
338337
Err: err,
@@ -428,7 +427,6 @@ func TestBestMatch(t *testing.T) {
428427
for name, test := range tests {
429428
childParsers := []Func[any]{}
430429
for _, res := range test.inputResults {
431-
res := res
432430
childParsers = append(childParsers, func([]rune) Result[any] {
433431
return res
434432
})
@@ -922,7 +920,6 @@ func TestMustBe(t *testing.T) {
922920
}
923921

924922
for name, test := range tests {
925-
test := test
926923
childParser := func([]rune) Result[any] {
927924
return test.inputRes
928925
}
@@ -981,7 +978,6 @@ func TestInterceptExpectedError(t *testing.T) {
981978
}
982979

983980
for name, test := range tests {
984-
test := test
985981
childParser := func([]rune) Result[any] {
986982
return test.inputRes
987983
}

‎internal/bloblang/parser/field_parser_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ func TestFieldExpressionParserErrors(t *testing.T) {
7575
}
7676

7777
for name, test := range tests {
78-
test := test
7978
t.Run(name, func(t *testing.T) {
8079
t.Parallel()
8180
_, err := ParseField(GlobalContext(), test.input)
@@ -196,7 +195,6 @@ func TestFieldExpressions(t *testing.T) {
196195
}
197196

198197
for name, test := range tests {
199-
test := test
200198
t.Run(name, func(t *testing.T) {
201199
t.Parallel()
202200

‎internal/bloblang/parser/mapping_parser_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ foo = bar.apply("foo")`, goodMapFile),
176176
}
177177

178178
for name, test := range tests {
179-
test := test
180179
t.Run(name, func(t *testing.T) {
181180
exec, err := ParseMapping(GlobalContext(), test.mapping)
182181
require.NotNil(t, err)
@@ -555,7 +554,6 @@ from "%v"`, directMapFile),
555554
}
556555

557556
for name, test := range tests {
558-
test := test
559557
t.Run(name, func(t *testing.T) {
560558
msg := message.QuickBatch(nil)
561559
for _, p := range test.input {

‎internal/bloblang/parser/query_arithmetic_parser_test.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,6 @@ func TestArithmeticParser(t *testing.T) {
302302
}
303303

304304
for name, test := range tests {
305-
test := test
306305
t.Run(name, func(t *testing.T) {
307306
t.Parallel()
308307

‎internal/bloblang/parser/query_expression_parser_test.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ func TestExpressionsParser(t *testing.T) {
255255
}
256256

257257
for name, test := range tests {
258-
test := test
259258
t.Run(name, func(t *testing.T) {
260259
t.Parallel()
261260

0 commit comments

Comments
 (0)