Fix tests to use mcp-server lint

Author: JakeSCahill

.github/workflows/test-mcp-examples.yaml

@@ -34,6 +34,11 @@ jobs:
       - name: Install doc-tools dependencies
         run: npx --no-install doc-tools install-test-dependencies
 
+      - name: Install yq
+        run: |
+          sudo wget -qO /usr/local/bin/yq https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64
+          sudo chmod +x /usr/local/bin/yq
+
       - name: Make test script executable
         run: chmod +x modules/ai-agents/examples/test-mcp-examples.sh
 

modules/ai-agents/examples/test-mcp-examples.sh

@@ -1,10 +1,9 @@
 #!/usr/bin/env bash
 #
-# Automated testing script for Redpanda Connect MCP examples (Cloud)
+# Automated testing script for Redpanda Connect MCP examples
 #
 # Usage:
-#   ./test-mcp-examples.sh                      # Test all examples
-#   ./test-mcp-examples.sh weather_*.yaml       # Test specific pattern
+#   ./test-mcp-examples.sh
 
 set -euo pipefail
 
@@ -17,95 +16,134 @@ NC='\033[0m'
 
 # Counters
 TOTAL=0
-PASSED=0
-FAILED=0
 SKIPPED=0
 MCP_FAILS=0
 
-echo "🧪 Redpanda Connect MCP Examples Test Suite (Cloud)"
-echo "===================================================="
+echo "🧪 Redpanda Connect MCP Examples Test Suite"
+echo "============================================"
 echo ""
 
-# Determine what to test
-PATTERN="${1:-*.yaml}"
-
-# Function to lint a config file
-lint_config() {
-    local file=$1
-    TOTAL=$((TOTAL + 1))
-
-    echo -n "  Linting $(basename "$file")... "
-
-    # Skip environment variable checks for MCP examples as they may use ${secrets.X}
-    if rpk connect lint --skip-env-var-check "$file" 2>&1 | grep -q "error"; then
-        echo -e "${RED}FAILED${NC}"
-        rpk connect lint --skip-env-var-check "$file" 2>&1 | sed 's/^/    /'
-        FAILED=$((FAILED + 1))
-        return 1
-    else
-        echo -e "${GREEN}PASSED${NC}"
-        PASSED=$((PASSED + 1))
-        return 0
-    fi
-}
+# Run MCP server lint on the directory
+echo "Running rpk connect mcp-server lint..."
+LINT_OUTPUT="/tmp/mcp_lint_$$.txt"
+if ! rpk connect mcp-server lint --skip-env-var-check 2>&1 | tee "$LINT_OUTPUT" > /dev/null; then
+    echo -e "${RED}❌ Linting failed${NC}"
+    echo ""
+    cat "$LINT_OUTPUT"
+    rm -f "$LINT_OUTPUT"
+    exit 1
+else
+    echo -e "${GREEN}✅ Linting passed${NC}"
+    rm -f "$LINT_OUTPUT"
+fi
+echo ""
 
 # Function to validate MCP metadata
 validate_mcp_metadata() {
     local file=$1
 
     echo -n "  Validating MCP metadata... "
 
-    # Check if file has MCP metadata
-    if ! grep -q "meta:" "$file" || ! grep -q "mcp:" "$file"; then
+    # Determine which YAML parser to use
+    local use_yq=true
+    if ! command -v yq &> /dev/null; then
+        use_yq=false
+        if ! command -v python3 &> /dev/null; then
+            echo -e "${RED}FAILED${NC} (neither yq nor python3 available)"
+            MCP_FAILS=$((MCP_FAILS + 1))
+            return 1
+        fi
+    fi
+
+    # Check if .meta.mcp exists
+    local mcp_exists
+    if $use_yq; then
+        mcp_exists=$(yq eval '.meta.mcp' "$file" 2>/dev/null)
+    else
+        mcp_exists=$(python3 -c "
+import yaml
+try:
+    with open('$file') as f:
+        doc = yaml.safe_load(f)
+    meta = doc.get('meta', {}) if doc else {}
+    mcp = meta.get('mcp')
+    print('null' if mcp is None else 'exists')
+except:
+    print('null')
+" 2>/dev/null)
+    fi
+
+    if [[ "$mcp_exists" == "null" || -z "$mcp_exists" ]]; then
         echo -e "${YELLOW}SKIPPED${NC} (no MCP metadata)"
         SKIPPED=$((SKIPPED + 1))
         return 0
     fi
 
-    # Check for required MCP fields
-    local has_enabled
-    local has_description
-    has_enabled=$(grep -c "enabled: true" "$file" || echo 0)
-    has_description=$(grep -c "description:" "$file" || echo 0)
+    # Read .meta.mcp.enabled
+    local enabled
+    if $use_yq; then
+        enabled=$(yq eval '.meta.mcp.enabled' "$file" 2>/dev/null)
+    else
+        enabled=$(python3 -c "
+import yaml
+try:
+    with open('$file') as f:
+        doc = yaml.safe_load(f)
+    enabled = doc.get('meta', {}).get('mcp', {}).get('enabled')
+    print('null' if enabled is None else str(enabled).lower())
+except:
+    print('null')
+" 2>/dev/null)
+    fi
 
-    if [[ $has_enabled -eq 0 ]]; then
+    if [[ "$enabled" != "true" ]]; then
         echo -e "${YELLOW}WARNING${NC} (mcp.enabled not set to true)"
         return 0
     fi
 
-    if [[ $has_description -eq 0 ]]; then
+    # Read .meta.mcp.description
+    local description
+    if $use_yq; then
+        description=$(yq eval '.meta.mcp.description' "$file" 2>/dev/null)
+    else
+        description=$(python3 -c "
+import yaml
+try:
+    with open('$file') as f:
+        doc = yaml.safe_load(f)
+    desc = doc.get('meta', {}).get('mcp', {}).get('description')
+    print('null' if desc is None or desc == '' else str(desc))
+except:
+    print('null')
+" 2>/dev/null)
+    fi
+
+    if [[ "$description" == "null" || -z "$description" ]]; then
         echo -e "${RED}FAILED${NC} (missing description)"
+        MCP_FAILS=$((MCP_FAILS + 1))
         return 1
     fi
 
     echo -e "${GREEN}PASSED${NC}"
     return 0
 }
 
-# Find and test all matching files
-for file in $PATTERN; do
+# Validate MCP metadata for each file
+for file in *.yaml; do
     if [[ -f "$file" ]]; then
+        TOTAL=$((TOTAL + 1))
         echo ""
-        echo -e "${BLUE}📄 Testing: $file${NC}"
-
-        # Lint the config
-        if lint_config "$file"; then
-            # Validate MCP metadata
-            if ! validate_mcp_metadata "$file"; then
-                MCP_FAILS=$((MCP_FAILS + 1))
-            fi
-        fi
+        echo -e "${BLUE}📄 Validating: $file${NC}"
+        validate_mcp_metadata "$file"
     fi
 done
 
 # Summary
 echo ""
-echo "===================================================="
+echo "============================================"
 echo "📊 Test Summary"
-echo "===================================================="
+echo "============================================"
 echo "Total configs tested: $TOTAL"
-echo -e "Passed: ${GREEN}$PASSED${NC}"
-echo -e "Failed: ${RED}$FAILED${NC}"
 if [[ $MCP_FAILS -gt 0 ]]; then
     echo -e "MCP validation failures: ${RED}$MCP_FAILS${NC}"
 fi
@@ -114,8 +152,7 @@ if [[ $SKIPPED -gt 0 ]]; then
 fi
 echo ""
 
-TOTAL_FAILURES=$((FAILED + MCP_FAILS))
-if [[ $TOTAL_FAILURES -gt 0 ]]; then
+if [[ $MCP_FAILS -gt 0 ]]; then
     echo -e "${RED}❌ Some tests failed${NC}"
     exit 1
 else