Skip to content

fix: CDC integration test failures after schema metadata changes#4067

Merged
josephwoodward merged 1 commit intomainfrom
fix/cdc-integration-tests
Mar 5, 2026
Merged

fix: CDC integration test failures after schema metadata changes#4067
josephwoodward merged 1 commit intomainfrom
fix/cdc-integration-tests

Conversation

@Jeffail
Copy link
Collaborator

@Jeffail Jeffail commented Mar 5, 2026

  • mysql_cdc: handle plain int and uint types in mapMessageColumn, which the MySQL CDC library can return for number columns
  • postgres_cdc: strip schema metadata in TestIntegrationPostgresMetadata since it is tested separately in TestIntegrationPostgresCDCSchemaMetadata

- mysql_cdc: handle plain `int` and `uint` types in mapMessageColumn,
  which the MySQL CDC library can return for number columns
- postgres_cdc: strip schema metadata in TestIntegrationPostgresMetadata
  since it is tested separately in TestIntegrationPostgresCDCSchemaMetadata
@claude
Copy link

claude bot commented Mar 5, 2026

Claude finished @Jeffail's task in 49s —— View job


Review

  • Read agent guidelines
  • Validate commits
  • Review code changes
  • Post summary

Commits

  1. fix: CDC integration test failures after schema metadata changes — The fix: prefix is not a recognized system name. Per commit policy, valid formats are system: message (with a known area), chore: message, or sentence-case for repo-wide changes. Since this touches both mysql and postgresql, a sentence-case message like Fix CDC integration test failures after schema metadata changes would be appropriate, or split into two system-scoped commits.

Review

Small, focused fix handling two CDC integration test issues. The MySQL change adds int and uint type switch cases consistent with the existing pattern. The PostgreSQL change strips schema metadata from a test that doesn't need to assert on it.

LGTM

@josephwoodward josephwoodward merged commit 571fa57 into main Mar 5, 2026
7 checks passed
@josephwoodward josephwoodward deleted the fix/cdc-integration-tests branch March 5, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants