Merge pull request #2174 from redpanda-data/refactor/remove-mobx-from-quotas-page

Remove mobx from quotas page

Author: jvorcak

backend/pkg/api/api_integration_test.go

@@ -63,6 +63,7 @@ func (s *APIIntegrationTestSuite) SetupSuite() {
 
 	ctx := context.Background()
 	container, err := redpanda.Run(ctx, testutil.RedpandaImage())
+	testutil.LogContainerLogsIfFailed(ctx, t, container, err)
 	require.NoError(err)
 	s.redpandaContainer = container
 

backend/pkg/api/connect/integration/api_suite_test.go

@@ -78,6 +78,7 @@ func (s *APISuite) SetupSuite() {
 		network.WithNetwork([]string{"redpanda"}, s.network),
 		redpanda.WithListener("redpanda:29092"),
 	)
+	testutil.LogContainerLogsIfFailed(ctx, t, container, err)
 	require.NoError(err)
 	s.redpandaContainer = container
 
@@ -99,6 +100,7 @@ func (s *APISuite) SetupSuite() {
 		[]string{"redpanda:29092"},
 		network.WithNetwork([]string{"kconnect"}, s.network),
 	)
+	testutil.LogContainerLogsIfFailed(ctx, t, kConnectContainer, err)
 	require.NoError(err)
 
 	s.kConnectContainer = kConnectContainer

backend/pkg/api/connect/integration/kafkaconnect_v1_test.go

@@ -132,6 +132,7 @@ func (s *APISuite) TestGetConnectorAndStatus_v1() {
 
 	// Run HTTPBin container
 	httpC, err := testutil.RunHTTPBinContainer(ctx, network.WithNetwork([]string{"httpbin", "local-httpbin"}, s.network))
+	testutil.LogContainerLogsIfFailed(ctx, t, httpC, err)
 	requireT.NoError(err)
 
 	client := v1connect.NewKafkaConnectServiceClient(http.DefaultClient, s.httpAddress())

backend/pkg/api/connect/integration/kafkaconnect_v1alpha2_test.go

@@ -132,6 +132,7 @@ func (s *APISuite) TestGetConnectorAndStatus_v1alpha2() {
 
 	// Run HTTPBin container
 	httpC, err := testutil.RunHTTPBinContainer(ctx, network.WithNetwork([]string{"httpbin", "local-httpbin"}, s.network))
+	testutil.LogContainerLogsIfFailed(ctx, t, httpC, err)
 	requireT.NoError(err)
 
 	client := v1alpha2connect.NewKafkaConnectServiceClient(http.DefaultClient, s.httpAddress())

backend/pkg/api/handle_kafka_connect_integration_test.go

@@ -51,6 +51,7 @@ func (s *APIIntegrationTestSuite) TestHandleCreateConnector() {
 		network.WithNetwork([]string{"redpanda"}, testNetwork),
 		redpanda.WithListener("redpanda:29092"),
 	)
+	testutil.LogContainerLogsIfFailed(ctx, t, redpandaContainer, err)
 	require.NoError(err)
 
 	seedBroker, err := redpandaContainer.KafkaSeedBroker(ctx)
@@ -68,6 +69,7 @@ func (s *APIIntegrationTestSuite) TestHandleCreateConnector() {
 		network.WithNetwork([]string{"kafka-connect"}, testNetwork),
 		testcontainers.WithLogConsumers(logConsumer),
 	)
+	testutil.LogContainerLogsIfFailed(ctx, t, connectContainer, err)
 	require.NoError(err)
 
 	// Register cleanup in correct order: containers first, then network

backend/pkg/console/console_integration_test.go

@@ -48,6 +48,7 @@ func (s *ConsoleIntegrationTestSuite) SetupSuite() {
 
 	ctx := context.Background()
 	container, err := redpanda.Run(ctx, testutil.RedpandaImage())
+	testutil.LogContainerLogsIfFailed(ctx, t, container, err)
 	require.NoError(err)
 	s.redpandaContainer = container
 

backend/pkg/serde/service_integration_test.go

@@ -117,6 +117,7 @@ func (s *SerdeIntegrationTestSuite) SetupSuite() {
 	ctx := t.Context()
 
 	redpandaContainer, err := redpanda.Run(ctx, testutil.RedpandaImage())
+	testutil.LogContainerLogsIfFailed(ctx, t, redpandaContainer, err)
 	require.NoError(err)
 
 	s.redpandaContainer = redpandaContainer

backend/pkg/testutil/container.go

@@ -0,0 +1,44 @@
+// Copyright 2024 Redpanda Data, Inc.
+//
+// Use of this software is governed by the Business Source License
+// included in the file https://github.com/redpanda-data/redpanda/blob/dev/licenses/bsl.md
+//
+// As of the Change Date specified in that file, in accordance with
+// the Business Source License, use of this software will be governed
+// by the Apache License, Version 2.0
+
+package testutil
+
+import (
+	"context"
+	"io"
+	"testing"
+
+	"github.com/testcontainers/testcontainers-go"
+)
+
+// LogContainerLogsIfFailed prints the container's logs to the test output when
+// err is non-nil. This is useful for debugging container startup failures in CI,
+// where the only clue is "container exited with code X" but no actual logs.
+func LogContainerLogsIfFailed(ctx context.Context, t testing.TB, container testcontainers.Container, err error) {
+	t.Helper()
+
+	if err == nil || container == nil {
+		return
+	}
+
+	rc, logErr := container.Logs(ctx)
+	if logErr != nil {
+		t.Logf("failed to retrieve container logs after error: %v", logErr)
+		return
+	}
+	defer rc.Close()
+
+	logs, readErr := io.ReadAll(rc)
+	if readErr != nil {
+		t.Logf("failed to read container logs after error: %v", readErr)
+		return
+	}
+
+	t.Logf("container logs (startup error: %v):\n%s", err, string(logs))
+}

frontend/.gitignore

@@ -158,3 +158,5 @@ dist
 
 # Gemini CLI
 .gemini/settings.json
+
+tests/**/playwright-report/