Skip to content

Commit ec4e442

Browse files
committed
fix: update proto import paths for ACL and TLS types
Update import paths after proto dependency reorganization: - ACL types moved from redpanda/core/common/acl_pb to v1/acl_pb - TLS types moved from shadow_link_pb to common/v1/tls_pb Affects shadowlink creation, editing, and detail views.
1 parent 21ba101 commit ec4e442

File tree

11 files changed

+21
-19
lines changed

11 files changed

+21
-19
lines changed

.github/workflows/buf.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,16 @@ jobs:
4444
runs-on: ubuntu-latest
4545
steps:
4646
- uses: actions/checkout@v5
47-
- name: Buf – lint, format & breaking
47+
- name: Buf – lint & format
4848
uses: bufbuild/buf-action@v1
4949
with:
5050
lint: true
5151
format: true
52-
breaking: true
53-
push: false # Only validate, don't push to registry
54-
# Compare against the default branch so the whole PR is checked
55-
breaking_against: https://github.com/redpanda-data/console.git#branch=master
56-
args: '--exclude-imports'
52+
breaking: false
53+
push: false
54+
- uses: bufbuild/buf-setup-action@v1
55+
- name: Buf – breaking (excluding imports)
56+
run: buf breaking --against 'https://github.com/redpanda-data/console.git#branch=master' --exclude-imports
5757

5858
# ===========================================================================
5959
# Job: push-to-registry (push events only - registry operations only)

frontend/src/components/pages/shadowlinks/create/configuration/acls-step.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import { zodResolver } from '@hookform/resolvers/zod';
1313
import { Form } from 'components/redpanda-ui/components/form';
14-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
14+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
1515
import { useForm } from 'react-hook-form';
1616
import { fireEvent, render, screen, waitFor, within } from 'test-utils';
1717

frontend/src/components/pages/shadowlinks/create/configuration/acls-step.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
} from 'components/redpanda-ui/components/select';
3131
import { Tabs, TabsContent, TabsList, TabsTrigger } from 'components/redpanda-ui/components/tabs';
3232
import { ChevronDown, Info, X } from 'lucide-react';
33-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
33+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
3434
import { useState } from 'react';
3535
import { useFieldArray, useFormContext, useWatch } from 'react-hook-form';
3636

frontend/src/components/pages/shadowlinks/create/model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
import { FilterType, PatternType, ScramMechanism } from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
13-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
13+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
1414
import { z } from 'zod';
1515

1616
// TLS mode: either file paths or PEM content

frontend/src/components/pages/shadowlinks/create/shadowlink-create-page.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ import {
3030
ShadowLinkClientOptionsSchema,
3131
ShadowLinkConfigurationsSchema,
3232
ShadowLinkSchema,
33-
TLSSettingsSchema,
3433
TopicMetadataSyncOptionsSchema,
3534
} from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
35+
import { TLSSettingsSchema } from 'protogen/redpanda/core/common/v1/tls_pb';
3636
import { useEffect } from 'react';
3737
import { useForm } from 'react-hook-form';
3838
import { useNavigate } from 'react-router-dom';
@@ -47,7 +47,7 @@ import {
4747
ACLPattern,
4848
ACLPermissionType,
4949
ACLResource,
50-
} from '../../../../protogen/redpanda/core/common/acl_pb';
50+
} from '../../../../protogen/redpanda/core/common/v1/acl_pb';
5151
import { useCreateShadowLinkMutation } from '../../../../react-query/api/shadowlink';
5252
import { buildTLSSettings } from '../edit/shadowlink-edit-utils';
5353

frontend/src/components/pages/shadowlinks/details/config/tls-certificates-config.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
import { Text } from 'components/redpanda-ui/components/typography';
13-
import type { TLSSettings } from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
13+
import type { TLSSettings } from 'protogen/redpanda/core/common/v1/tls_pb';
1414
import type React from 'react';
1515

1616
const ConfigField = ({ label, value, testId }: { label: string; value: React.ReactNode; testId?: string }) => (

frontend/src/components/pages/shadowlinks/edit/get-update-values-for-acls.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
import { ScramMechanism } from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
13-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
13+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
1414
import { describe, expect, test } from 'vitest';
1515

1616
import { getUpdateValuesForACLs } from './shadowlink-edit-utils';

frontend/src/components/pages/shadowlinks/edit/shadowlink-edit-page.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import {
2626
ShadowLinkState,
2727
TopicMetadataSyncOptionsSchema,
2828
} from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
29-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
29+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
3030
import { MemoryRouter, Route, Routes } from 'react-router-dom';
3131
import { beforeEach, describe, expect, test, vi } from 'vitest';
3232

frontend/src/components/pages/shadowlinks/edit/shadowlink-edit-utils.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,15 @@ import {
2323
SecuritySettingsSyncOptionsSchema,
2424
type ShadowLinkClientOptions,
2525
ShadowLinkClientOptionsSchema,
26+
TopicMetadataSyncOptionsSchema,
27+
} from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
28+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
29+
import {
2630
TLSFileSettingsSchema,
2731
TLSPEMSettingsSchema,
2832
type TLSSettings,
2933
TLSSettingsSchema,
30-
TopicMetadataSyncOptionsSchema,
31-
} from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
32-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
34+
} from 'protogen/redpanda/core/common/v1/tls_pb';
3335

3436
import type { FormValues } from '../create/model';
3537
import { TLS_MODE } from '../create/model';

frontend/src/components/pages/shadowlinks/shadowlink-helpers.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
import { FilterType, PatternType } from 'protogen/redpanda/core/admin/v2/shadow_link_pb';
13-
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/acl_pb';
13+
import { ACLOperation, ACLPattern, ACLPermissionType, ACLResource } from 'protogen/redpanda/core/common/v1/acl_pb';
1414
import { describe, expect, test } from 'vitest';
1515

1616
import {

0 commit comments

Comments
 (0)