refactor: use core proto ShadowLinkTaskStatus in console and dataplane APIs #2054
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
c-julin
force-pushed
the
jc/shadowlink-task-status-update
branch
from
33a589f to
fb17156
Compare
| push: false | ||
| - uses: bufbuild/buf-setup-action@v1 | ||
| - name: Buf – breaking (excluding imports) | ||
| run: buf breaking --against 'https://github.com/redpanda-data/console.git#branch=master' --exclude-imports |
There was a problem hiding this comment.
adding this in but can be temporary but because of the core breaking changes this rule fails
There was a problem hiding this comment.
You can also add a label to this PR and introduce a breaking change: https://buf.build/docs/bsr/ci-cd/github-actions/#skip-breaking-change-detection-using-labels, which can help us in the future as we introduce more changes from alpha/beta versions.
…e APIs Remove duplicate TaskState enum and ShadowLinkTaskStatus message from console/v1alpha1 and dataplane/v1alpha3 protos. Both now reference core.admin.v2.ShadowLinkTaskStatus. Update buf.build/redpandadata/core to latest SHA and regenerate protos. Update frontend imports to use core proto types and adjust field name from shardId to shard.
Configure buf breaking change detection to ignore changes in external dependencies (buf.build/redpandadata/core) using --exclude-imports flag in CI workflow. Add secret.proto to ignore list and enable ignore_unstable_packages to handle dependency version changes.
Update import paths after proto dependency reorganization: - ACL types moved from redpanda/core/common/acl_pb to v1/acl_pb - TLS types moved from shadow_link_pb to common/v1/tls_pb Affects shadowlink creation, editing, and detail views.
c-julin
force-pushed
the
jc/shadowlink-task-status-update
branch
from
fb17156 to
d0e93c6
Compare
r-vasquez
left a comment
r-vasquez
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this. Just 1 comment on the CI, let me know how you want to handle it 👍
| push: false | ||
| - uses: bufbuild/buf-setup-action@v1 | ||
| - name: Buf – breaking (excluding imports) | ||
| run: buf breaking --against 'https://github.com/redpanda-data/console.git#branch=master' --exclude-imports |
There was a problem hiding this comment.
You can also add a label to this PR and introduce a breaking change: https://buf.build/docs/bsr/ci-cd/github-actions/#skip-breaking-change-detection-using-labels, which can help us in the future as we introduce more changes from alpha/beta versions.
Summary
TaskStateenum andShadowLinkTaskStatusmessage definitions from console and dataplane protosv1alpha1) and dataplane (v1alpha3) shadowlink protos to use the sharedcore.admin.v2.ShadowLinkTaskStatustypebuf.build/redpandadata/coreto latest versionshardinstead ofshardId)Test plan
task proto:generate)bun run lint)task backend:lint)