refactor: use core proto ShadowLinkTaskStatus in console and dataplane APIs #2054
+1,021
−1,444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
c-julin
force-pushed
the
jc/shadowlink-task-status-update
branch
from
33a589f to
fb17156
Compare
c-julin
commented
Dec 1, 2025
…e APIs Remove duplicate TaskState enum and ShadowLinkTaskStatus message from console/v1alpha1 and dataplane/v1alpha3 protos. Both now reference core.admin.v2.ShadowLinkTaskStatus. Update buf.build/redpandadata/core to latest SHA and regenerate protos. Update frontend imports to use core proto types and adjust field name from shardId to shard.
Configure buf breaking change detection to ignore changes in external dependencies (buf.build/redpandadata/core) using --exclude-imports flag in CI workflow. Add secret.proto to ignore list and enable ignore_unstable_packages to handle dependency version changes.
Update import paths after proto dependency reorganization: - ACL types moved from redpanda/core/common/acl_pb to v1/acl_pb - TLS types moved from shadow_link_pb to common/v1/tls_pb Affects shadowlink creation, editing, and detail views.
c-julin
force-pushed
the
jc/shadowlink-task-status-update
branch
from
fb17156 to
d0e93c6
Compare
r-vasquez
reviewed
Dec 1, 2025
Contributor
r-vasquez
left a comment
r-vasquez
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this. Just 1 comment on the CI, let me know how you want to handle it 👍
Remove the --exclude-imports flag from buf breaking change detection to properly validate all proto changes including imported dependencies. Also remove secret.proto from ignore list and ignore_unstable_packages setting from buf.yaml. This reverts the changes made in commits: - 4c25c2a: fix: exclude imported proto breaking changes from CI validation - ec4e442: fix: update proto import paths for ACL and TLS types (partial)
c-julin
force-pushed
the
jc/shadowlink-task-status-update
branch
from
67bd6a7 to
18a0f11
Compare
Add topic_id as field 2 in ShadowTopic and GetShadowTopicResponse messages to support topic identification beyond name. Regenerated backend Go, frontend TypeScript, and OpenAPI specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TaskStateenum andShadowLinkTaskStatusmessage definitions from console and dataplane protosv1alpha1) and dataplane (v1alpha3) shadowlink protos to use the sharedcore.admin.v2.ShadowLinkTaskStatustypebuf.build/redpandadata/coreto latest versionshardinstead ofshardId)Test plan
task proto:generate)bun run lint)task backend:lint)