Make bootstrap user generated password immutable

(cherry picked from commit 2f35544)

Author: andrewstucki

.changes/unreleased/charts-redpanda-Changed-20250618-182809.yaml

@@ -0,0 +1,4 @@
+project: charts/redpanda
+kind: Changed
+body: The generated bootstrap user password secret is now immutable. It was always intended to be a single-time generation, and now that is enforced at the Kubernetes API layer.
+time: 2025-06-18T18:28:09.325375-04:00

charts/redpanda/secrets.go

@@ -213,6 +213,8 @@ func SecretBootstrapUser(dot *helmette.Dot) *corev1.Secret {
 	// that a password be explicitly set?
 	// See also: https://github.com/redpanda-data/helm-charts/issues/1596
 	if existing, ok := helmette.Lookup[corev1.Secret](dot, dot.Release.Namespace, secretName); ok {
+		// make any existing secret immutable
+		existing.Immutable = ptr.To(true)
 		return existing
 	}
 
@@ -233,7 +235,8 @@ func SecretBootstrapUser(dot *helmette.Dot) *corev1.Secret {
 			Namespace: dot.Release.Namespace,
 			Labels:    FullLabels(dot),
 		},
-		Type: corev1.SecretTypeOpaque,
+		Immutable: ptr.To(true),
+		Type:      corev1.SecretTypeOpaque,
 		StringData: map[string]string{
 			"password": password,
 		},

charts/redpanda/templates/_secrets.go.tpl

@@ -101,6 +101,7 @@
 {{- $existing_4 := (index $_209_existing_4_ok_5 0) -}}
 {{- $ok_5 := (index $_209_existing_4_ok_5 1) -}}
 {{- if $ok_5 -}}
+{{- $_ := (set $existing_4 "immutable" true) -}}
 {{- $_is_returning = true -}}
 {{- (dict "r" $existing_4) | toJson -}}
 {{- break -}}
@@ -111,7 +112,7 @@
 {{- $password = $userPassword -}}
 {{- end -}}
 {{- $_is_returning = true -}}
-{{- (dict "r" (mustMergeOverwrite (dict "metadata" (dict "creationTimestamp" (coalesce nil))) (mustMergeOverwrite (dict) (dict "apiVersion" "v1" "kind" "Secret")) (dict "metadata" (mustMergeOverwrite (dict "creationTimestamp" (coalesce nil)) (dict "name" $secretName "namespace" $dot.Release.Namespace "labels" (get (fromJson (include "redpanda.FullLabels" (dict "a" (list $dot)))) "r"))) "type" "Opaque" "stringData" (dict "password" $password)))) | toJson -}}
+{{- (dict "r" (mustMergeOverwrite (dict "metadata" (dict "creationTimestamp" (coalesce nil))) (mustMergeOverwrite (dict) (dict "apiVersion" "v1" "kind" "Secret")) (dict "metadata" (mustMergeOverwrite (dict "creationTimestamp" (coalesce nil)) (dict "name" $secretName "namespace" $dot.Release.Namespace "labels" (get (fromJson (include "redpanda.FullLabels" (dict "a" (list $dot)))) "r"))) "immutable" true "type" "Opaque" "stringData" (dict "password" $password)))) | toJson -}}
 {{- break -}}
 {{- end -}}
 {{- end -}}

charts/redpanda/testdata/template-cases.golden.txtar

@@ -4910,6 +4910,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null
@@ -6366,6 +6367,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null
@@ -16985,6 +16987,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null
@@ -76956,6 +76959,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null
@@ -89354,6 +89358,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null
@@ -94499,6 +94504,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null
@@ -157581,6 +157587,7 @@ type: Opaque
 ---
 # Source: redpanda/templates/entry-point.yaml
 apiVersion: v1
+immutable: true
 kind: Secret
 metadata:
   creationTimestamp: null