operator: remove vectorized console controller

This commit removes the entire implementation of the vectorized (operator v1)
console controller. This controller was unused as cloud has moved to the helm
chart for installation. Due to it's usage of an outdated version of console's
config package, it was causing dependency conflicts.

Rather than updating the unused controlled, it's being removed. The CRD will
remain to prevent any difficult with downstream consumers (e.g. cloud).

Author: chrisseto

licenses/third_party.md

@@ -74,7 +74,6 @@ run `task generate:third-party-licenses-list`
 | github.com/containerd/platforms | [Apache-2.0](https://github.com/containerd/platforms/blob/v0.2.1/LICENSE) |
 | github.com/cyphar/filepath-securejoin | [BSD-3-Clause](https://github.com/cyphar/filepath-securejoin/blob/v0.4.1/LICENSE) |
 | github.com/davecgh/go-spew/spew | [ISC](https://github.com/davecgh/go-spew/blob/d8f796af33cc/LICENSE) |
-| github.com/distribution/reference | [Apache-2.0](https://github.com/distribution/reference/blob/v0.6.0/LICENSE) |
 | github.com/emicklei/go-restful/v3 | [MIT](https://github.com/emicklei/go-restful/blob/v3.12.2/LICENSE) |
 | github.com/evanphx/json-patch | [BSD-3-Clause](https://github.com/evanphx/json-patch/blob/v5.9.11/LICENSE) |
 | github.com/evanphx/json-patch/v5 | [BSD-3-Clause](https://github.com/evanphx/json-patch/blob/v5.9.11/v5/LICENSE) |

operator/chart/files/rbac/v1-manager.ClusterRole.yaml

@@ -16,20 +16,6 @@ rules:
       - patch
       - update
       - watch
-  - apiGroups:
-      - ""
-    resources:
-      - events
-      - secrets
-      - serviceaccounts
-      - services
-    verbs:
-      - create
-      - get
-      - list
-      - patch
-      - update
-      - watch
   - apiGroups:
       - ""
     resources:
@@ -66,10 +52,22 @@ rules:
     verbs:
       - patch
       - update
+  - apiGroups:
+      - ""
+    resources:
+      - secrets
+      - serviceaccounts
+      - services
+    verbs:
+      - create
+      - get
+      - list
+      - patch
+      - update
+      - watch
   - apiGroups:
       - apps
     resources:
-      - deployments
       - statefulsets
     verbs:
       - create
@@ -133,7 +131,6 @@ rules:
       - redpanda.vectorized.io
     resources:
       - clusters
-      - consoles
     verbs:
       - create
       - delete
@@ -146,15 +143,13 @@ rules:
       - redpanda.vectorized.io
     resources:
       - clusters/finalizers
-      - consoles/finalizers
     verbs:
       - patch
       - update
   - apiGroups:
       - redpanda.vectorized.io
     resources:
       - clusters/status
-      - consoles/status
     verbs:
       - get
       - patch

operator/cmd/run/run.go

@@ -39,7 +39,6 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
-	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 
 	vectorizedv1alpha1 "github.com/redpanda-data/redpanda-operator/operator/api/vectorized/v1alpha1"
 	"github.com/redpanda-data/redpanda-operator/operator/cmd/version"
@@ -53,10 +52,8 @@ import (
 	"github.com/redpanda-data/redpanda-operator/operator/internal/lifecycle"
 	adminutils "github.com/redpanda-data/redpanda-operator/operator/pkg/admin"
 	internalclient "github.com/redpanda-data/redpanda-operator/operator/pkg/client"
-	consolepkg "github.com/redpanda-data/redpanda-operator/operator/pkg/console"
 	pkglabels "github.com/redpanda-data/redpanda-operator/operator/pkg/labels"
 	"github.com/redpanda-data/redpanda-operator/operator/pkg/resources"
-	redpandawebhooks "github.com/redpanda-data/redpanda-operator/operator/webhooks/redpanda"
 	"github.com/redpanda-data/redpanda-operator/pkg/otelutil/log"
 	pkgsecrets "github.com/redpanda-data/redpanda-operator/pkg/secrets"
 )
@@ -595,39 +592,13 @@ func setupVectorizedControllers(ctx context.Context, mgr ctrl.Manager, cloudExpa
 		return err
 	}
 
-	if err := (&vectorizedcontrollers.ConsoleReconciler{
-		Client:                  mgr.GetClient(),
-		Scheme:                  mgr.GetScheme(),
-		Log:                     ctrl.Log.WithName("controllers").WithName("redpanda").WithName("Console"),
-		AdminAPIClientFactory:   adminAPIClientFactory,
-		Store:                   consolepkg.NewStore(mgr.GetClient(), mgr.GetScheme()),
-		EventRecorder:           mgr.GetEventRecorderFor("Console"),
-		KafkaAdminClientFactory: consolepkg.NewKafkaAdmin,
-	}).WithClusterDomain(opts.clusterDomain).SetupWithManager(mgr); err != nil {
-		log.Error(ctx, err, "unable to create controller", "controller", "Console")
-		return err
-	}
-
 	// Setup webhooks
 	if opts.webhookEnabled {
 		log.Info(ctx, "Setup webhook")
 		if err := (&vectorizedv1alpha1.Cluster{}).SetupWebhookWithManager(mgr); err != nil {
 			log.Error(ctx, err, "Unable to create webhook", "webhook", "RedpandaCluster")
 			return err
 		}
-		hookServer := mgr.GetWebhookServer()
-		hookServer.Register("/mutate-redpanda-vectorized-io-v1alpha1-console", &webhook.Admission{
-			Handler: &redpandawebhooks.ConsoleDefaulter{
-				Client:  mgr.GetClient(),
-				Decoder: admission.NewDecoder(mgr.GetScheme()),
-			},
-		})
-		hookServer.Register("/validate-redpanda-vectorized-io-v1alpha1-console", &webhook.Admission{
-			Handler: &redpandawebhooks.ConsoleValidator{
-				Client:  mgr.GetClient(),
-				Decoder: admission.NewDecoder(mgr.GetScheme()),
-			},
-		})
 	}
 
 	if opts.enableGhostBrokerDecommissioner {

operator/config/rbac/bases/operator/role.yaml

@@ -26,11 +26,7 @@ rules:
   - events
   verbs:
   - create
-  - get
-  - list
   - patch
-  - update
-  - watch
 - apiGroups:
   - ""
   resources:
@@ -264,7 +260,6 @@ rules:
   - redpanda.vectorized.io
   resources:
   - clusters
-  - consoles
   verbs:
   - create
   - delete
@@ -277,15 +272,13 @@ rules:
   - redpanda.vectorized.io
   resources:
   - clusters/finalizers
-  - consoles/finalizers
   verbs:
   - patch
   - update
 - apiGroups:
   - redpanda.vectorized.io
   resources:
   - clusters/status
-  - consoles/status
   verbs:
   - get
   - patch

operator/config/rbac/itemized/v1-manager.yaml

@@ -16,20 +16,6 @@ rules:
   - patch
   - update
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - events
-  - secrets
-  - serviceaccounts
-  - services
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - update
-  - watch
 - apiGroups:
   - ""
   resources:
@@ -66,10 +52,22 @@ rules:
   verbs:
   - patch
   - update
+- apiGroups:
+  - ""
+  resources:
+  - secrets
+  - serviceaccounts
+  - services
+  verbs:
+  - create
+  - get
+  - list
+  - patch
+  - update
+  - watch
 - apiGroups:
   - apps
   resources:
-  - deployments
   - statefulsets
   verbs:
   - create
@@ -133,7 +131,6 @@ rules:
   - redpanda.vectorized.io
   resources:
   - clusters
-  - consoles
   verbs:
   - create
   - delete
@@ -146,15 +143,13 @@ rules:
   - redpanda.vectorized.io
   resources:
   - clusters/finalizers
-  - consoles/finalizers
   verbs:
   - patch
   - update
 - apiGroups:
   - redpanda.vectorized.io
   resources:
   - clusters/status
-  - consoles/status
   verbs:
   - get
   - patch

operator/config/webhook/manifests.yaml

@@ -25,26 +25,6 @@ webhooks:
     resources:
     - clusters
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /mutate-redpanda-vectorized-io-v1alpha1-console
-  failurePolicy: Fail
-  name: mconsole.kb.io
-  rules:
-  - apiGroups:
-    - redpanda.vectorized.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    - UPDATE
-    resources:
-    - consoles
-  sideEffects: None
 ---
 apiVersion: admissionregistration.k8s.io/v1
 kind: ValidatingWebhookConfiguration
@@ -72,23 +52,3 @@ webhooks:
     resources:
     - clusters
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-redpanda-vectorized-io-v1alpha1-console
-  failurePolicy: Fail
-  name: vconsole.kb.io
-  rules:
-  - apiGroups:
-    - redpanda.vectorized.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    - UPDATE
-    resources:
-    - consoles
-  sideEffects: None

operator/go.mod

@@ -7,9 +7,7 @@ require (
 	github.com/Masterminds/sprig/v3 v3.3.0
 	github.com/cert-manager/cert-manager v1.14.5
 	github.com/cisco-open/k8s-objectmatcher v1.9.0
-	github.com/cloudhut/common v0.10.0
 	github.com/cockroachdb/errors v1.11.3
-	github.com/distribution/reference v0.6.0
 	github.com/fluxcd/pkg/runtime v0.43.3
 	github.com/fsnotify/fsnotify v1.9.0
 	github.com/go-logr/logr v1.4.2
@@ -120,6 +118,7 @@ require (
 	github.com/cenkalti/backoff/v5 v5.0.2 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/chai2010/gettext-go v1.0.2 // indirect
+	github.com/cloudhut/common v0.10.0 // indirect
 	github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b // indirect
 	github.com/cockroachdb/redact v1.1.5 // indirect
 	github.com/containerd/containerd v1.7.27 // indirect
@@ -130,6 +129,7 @@ require (
 	github.com/cyphar/filepath-securejoin v0.4.1 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
+	github.com/distribution/reference v0.6.0 // indirect
 	github.com/docker/docker v27.5.1+incompatible // indirect
 	github.com/docker/go-connections v0.5.0 // indirect
 	github.com/docker/go-units v0.5.0 // indirect