Skip to content

Commit e03b720

Browse files
committed
[K8S-535] charts/*: close values' schemas
Prior to this commit our charts' schemas were "open" which allowed extraneous keys to be specified without repercussions. This had lead to many cases of users having values files that "didn't work" due to incorrect key names, indentation issues, etc. As we're pushing out new major releases with breaking changes along side core's 25.1 release, this commit "closes" the charts' schemas which catch any incompatible values or unexpected upgrades.
1 parent 0c6ebb6 commit e03b720

38 files changed

+2108
-611
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
project: charts/connectors
2+
kind: Changed
3+
body: |-
4+
`values.schema.json` is now "closed" (`additionalProperties: false`)
5+
6+
Any unexpected values will result in a validation error,previously they would
7+
have been ignored.
8+
time: 2025-03-21T12:30:10.318939-04:00
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
project: charts/console
2+
kind: Changed
3+
body: |-
4+
`values.schema.json` is now "closed" (`additionalProperties: false`)
5+
6+
Any unexpected values will result in a validation error,previously they would
7+
have been ignored.
8+
time: 2025-03-21T12:30:10.318939-04:00
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
project: charts/operator
2+
kind: Changed
3+
body: |-
4+
`values.schema.json` is now "closed" (`additionalProperties: false`)
5+
6+
Any unexpected values will result in a validation error,previously they would
7+
have been ignored.
8+
time: 2025-03-21T12:30:10.318939-04:00
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
project: charts/redpanda
2+
kind: Changed
3+
body: |-
4+
`values.schema.json` is now "closed" (`additionalProperties: false`)
5+
6+
Any unexpected values will result in a validation error,previously they would
7+
have been ignored.
8+
time: 2025-03-21T12:30:10.318935-04:00

charts/connectors/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
55
and is generated by [Changie](https://github.com/miniscruff/changie).
66

77

8+
## Unreleased
9+
### Changed
10+
* `values.schema.json` is now "closed" (`additionalProperties: false`)
11+
12+
Any unexpected values will result in a validation error,previously they would
13+
have been ignored.
14+
815
### [0.1.14](https://github.com/redpanda-data/helm-charts/releases/tag/connectors-0.1.14) - 2024-11-20
916
#### Added
1017
* Enabled flag that would be only used by Redpanda chart when partial values will be embedded into Redpanda values struct

charts/connectors/values.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
var DefaultValuesYAML []byte
2626

2727
type Values struct {
28+
Globals map[string]any `json:"global,omitempty"`
2829
NameOverride string `json:"nameOverride"`
2930
FullnameOverride string `json:"fullnameOverride"`
3031
CommonLabels map[string]string `json:"commonLabels"`

charts/connectors/values_partial.gen.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

charts/console/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ and is generated by [Changie](https://github.com/miniscruff/changie).
2828
- `secret.enterprise.license` has been moved to `secret.license`.
2929
- `enterprise` has been removed.
3030
- `enterprise.licenseSecretRef` has been moved to `licenseSecretRef`.
31+
* `values.schema.json` is now "closed" (`additionalProperties: false`)
32+
33+
Any unexpected values will result in a validation error,previously they would
34+
have been ignored.
3135

3236
### [0.7.31](https://github.com/redpanda-data/helm-charts/releases/tag/console-0.7.31) - 2024-12-06
3337
#### Added

charts/console/values.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ var (
2727
)
2828

2929
type Values struct {
30+
Globals map[string]any `json:"global,omitempty"`
3031
ReplicaCount int32 `json:"replicaCount"`
3132
Image Image `json:"image"`
3233
ImagePullSecrets []corev1.LocalObjectReference `json:"imagePullSecrets"`

0 commit comments

Comments
 (0)