charts/console: remove all helmette.Dot references
#1065
Conversation
chrisseto
force-pushed
the
chris/p/console-extract-dot
branch
from
43bf657 to
3657a7d
Compare
chrisseto
force-pushed
the
chris/p/console-split-chart2
branch
from
b91b220 to
aa400ef
Compare
chrisseto
force-pushed
the
chris/p/console-extract-dot
branch
2 times, most recently
from
135556b to
e730bc9
Compare
chrisseto
force-pushed
the
chris/p/console-extract-dot
branch
from
e730bc9 to
2379697
Compare
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
| github.com/redpanda-data/common-go/secrets v0.1.3 | ||
| github.com/redpanda-data/console/backend v0.0.0-20240303221210-05d5d9e85f20 | ||
| github.com/redpanda-data/redpanda-operator/charts/console/v3 v3.1.0 | ||
| github.com/redpanda-data/redpanda-operator/charts/console v0.0.0-20250718150737-e01f8476d560 |
There was a problem hiding this comment.
Why not v3.0.0-XXXX-YYYY?
I vaguely remember that package version is required to correctly reference major version tagged in git repo.
There was a problem hiding this comment.
I changed the import in the JSON compat test back to console v2 as those are the values that it's supposed to be compatible with.
| github.com/prometheus/client_model v0.6.2 // indirect | ||
| github.com/prometheus/procfs v0.16.1 // indirect | ||
| github.com/quasilyte/go-ruleguard/dsl v0.3.22 // indirect | ||
| github.com/redpanda-data/redpanda-operator/charts/console/v3 v3.1.0 // indirect |
There was a problem hiding this comment.
Why this indirect import is present if we have
github.com/redpanda-data/redpanda-operator/charts/console v0.0.0-20250718150737-e01f8476d560
There was a problem hiding this comment.
The v3 dep is indirect through the redpanda v25 chart.
So:
operator --> Console v2 (JSON compat tests)
| ---> Redpanda v25 --> Console v3 (Through rendering)
Good catch though, I didn't realize it until you pointed it out!
RafalKorepta
left a comment
RafalKorepta
left a comment
There was a problem hiding this comment.
LGTM, but I think imported package in operator/go.mod is wrong.
|
Just to sum up, the import changes are correct and technically expected though a bit funky. It should make more sense once #1071 is merged. |
No description provided.