charts/redpanda: fix mTLS #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
Contributor
Author
|
Lesson learned: PRs need to be rebased before deleting the branch they're targeting. #1100 |
Prior to this commit the chart had a variety of bugs around mTLS. The majority of them were incorrect path construction and handling of `.clientSecretRef`. The primary issue, though, is that the chart incorrectly mints a single client certificate regardless of how many trust chains are in use. This commit moves all name and path references into helper methods onto the `TLSCert` itself and generates client certs per unique trust chain with client auth enabled. K8S-719
chrisseto
force-pushed
the
chris/p/redpanda-mtls-fix
branch
from
2def69f to
cde7c52
Compare
chrisseto
commented
Sep 24, 2025
| return err | ||
|
|
||
| case <-ctx.Done(): | ||
| _ = cmd.Process.Signal(os.Interrupt) |
Contributor
Author
There was a problem hiding this comment.
Found an edge case in CI and locally that's pretty hard to reproduce. It's possible for Process to be nil here. It's unlikely to recur but I went ahead and fix it by using Cancel and WaitDelay instead.
It seems the only way this can be triggered is if ctx is cancelled ahead of cmd.Run actually executing. Using .Cancel performs the appropriate checks and would otherwise require reimplementing parts of .Run.
RafalKorepta
approved these changes
Sep 24, 2025
This was referenced Sep 25, 2025
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the chart had a variety of bugs around mTLS. The majority of them were incorrect path construction and handling of
.clientSecretRef. The primary issue, though, is that the chart incorrectly mints a single client certificate regardless of how many trust chains are in use.This commit moves all name and path references into helper methods onto the
TLSCertitself and generates client certs per unique trust chain with client auth enabled.K8S-719