[release/v2.4.x] charts/redpanda: fix mTLS #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
RafalKorepta,
andrewstucki,
chrisseto and
gene-redpanda
as code owners
Author
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
chrisseto
force-pushed
the
backport/release/v2.4.x/pr-1112
branch
from
c32eeac to
56bf801
Compare
Contributor
|
integration tests are failing and I haven't updated the golden file just yet as I need to review them for correctness but all conflicts have been fixed. |
chrisseto
force-pushed
the
backport/release/v2.4.x/pr-1112
branch
from
56bf801 to
d36b90c
Compare
Prior to this commit the chart had a variety of bugs around mTLS. The majority of them were incorrect path construction and handling of `.clientSecretRef`. The primary issue, though, is that the chart incorrectly mints a single client certificate regardless of how many trust chains are in use. This commit moves all name and path references into helper methods onto the `TLSCert` itself and generates client certs per unique trust chain with client auth enabled. K8S-719 (cherry picked from commit 6c63e57)
chrisseto
force-pushed
the
backport/release/v2.4.x/pr-1112
branch
from
d36b90c to
6f032de
Compare
chrisseto
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease/v2.4.x:Questions ?
Please refer to the Backport tool documentation