-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for v1 clusters for users, roles, topics, and schemas #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RafalKorepta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I don't see acceptance test for schema registry and topic custom resource.
| And there are the following pre-existing users in vectorized cluster "sasl" | ||
| | name | password | mechanism | | ||
| | charlie | password | SCRAM-SHA-256 | | ||
| When I create topic "public-test" in vectorized cluster "sasl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this step be replaced with Topic custom resource. I understand test should as much as possible test isolated features/changes, but I think acceptance test suite can combine more custom resources under test.
|
@RafalKorepta for the other acceptance tests, I wanted to do those separately just to keep the initial implementation diff light while still exercising the majority of the code paths I changed. I’ll try and add the tests for the other resources as a follow up, but that may or may not also end up tacking on a bunch of time to our acceptance tests, so wanted to experiment some with structuring those. |
This adds v1 cluster support for User, Role, Topic, and Schema types (topics haven't been moved to use
ResourceControlleryet, so those haven't been touched). It modifies and extends our acceptance tests to be able to handle connections to v1 clusters and adds in a duplicate set of tests for Roles to ensure they work the same with v1 or v2 clusters.The flag for having v1 cluster support is the same as elsewhere, it just leans on the
enable-vectorized-controllersoption.