Skip to content

Conversation

@andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Oct 1, 2025

This adds v1 cluster support for User, Role, Topic, and Schema types (topics haven't been moved to use ResourceController yet, so those haven't been touched). It modifies and extends our acceptance tests to be able to handle connections to v1 clusters and adds in a duplicate set of tests for Roles to ensure they work the same with v1 or v2 clusters.

The flag for having v1 cluster support is the same as elsewhere, it just leans on the enable-vectorized-controllers option.

@andrewstucki andrewstucki changed the title Add support for v1 clusters for users, roles, and schemas Add support for v1 clusters for users, roles, topics, and schemas Oct 1, 2025
@andrewstucki andrewstucki enabled auto-merge (squash) October 1, 2025 20:55
@andrewstucki andrewstucki requested a review from chrisseto October 1, 2025 20:56
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't see acceptance test for schema registry and topic custom resource.

And there are the following pre-existing users in vectorized cluster "sasl"
| name | password | mechanism |
| charlie | password | SCRAM-SHA-256 |
When I create topic "public-test" in vectorized cluster "sasl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this step be replaced with Topic custom resource. I understand test should as much as possible test isolated features/changes, but I think acceptance test suite can combine more custom resources under test.

@andrewstucki andrewstucki merged commit 78e2911 into main Oct 2, 2025
10 checks passed
@andrewstucki
Copy link
Contributor Author

@RafalKorepta for the other acceptance tests, I wanted to do those separately just to keep the initial implementation diff light while still exercising the majority of the code paths I changed. I’ll try and add the tests for the other resources as a follow up, but that may or may not also end up tacking on a bunch of time to our acceptance tests, so wanted to experiment some with structuring those.

@RafalKorepta RafalKorepta deleted the as/v1-user-acl-schemas branch December 12, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants