[release/v25.1.x] pkg/kube: require namespace in Ctl.List
#1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
RafalKorepta,
andrewstucki,
chrisseto and
gene-redpanda
as code owners
Contributor
|
This will be blocked until #1124 is merged due to the dependency on the 5.10.x chart. |
chrisseto
force-pushed
the
backport/release/v25.1.x/pr-1121
branch
2 times, most recently
from
a84d752 to
708164c
Compare
chrisseto
approved these changes
Oct 2, 2025
`client.Client` and `kube.Ctl` treated `namespace` (`client.InNamespace`) as an optional parameter. If not provided, it default to `"default"`. This parameter has been missed multiple times across various places in our codebase and resulted in latent errors, often because tests utilised the default namespace. This commit changes the signature of `Ctl.List` to require a `namespace string` parameter to make it impossible to forget. It additionally adds it to a few places (lifecycle client) that it was previously forgotten. (cherry picked from commit 9e08d14) # Conflicts: # charts/redpanda/chart_test.go # go.work.sum # operator/internal/controller/vectorized/cluster_controller_test.go # operator/internal/lifecycle/client.go # pkg/kube/ctl.go # pkg/kube/syncer.go # pkg/kube/syncer_test.go
chrisseto
force-pushed
the
backport/release/v25.1.x/pr-1121
branch
from
708164c to
24d3da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease/v25.1.x:Questions ?
Please refer to the Backport tool documentation