Skip to content

[release/v2.3.x] operator: various sidecar fixes #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisseto merged 1 commit into from
Nov 4, 2025
Merged

[release/v2.3.x] operator: various sidecar fixes #1153

chrisseto merged 1 commit into from
Nov 4, 2025

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Oct 21, 2025

Backport

This will backport the following commits from main to release/v2.3.x:

Questions ?

Please refer to the Backport tool documentation

@github-actions github-actions bot mentioned this pull request Oct 21, 2025
Merged
@github-actions
Copy link
Author

github-actions bot commented Oct 27, 2025

This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Oct 27, 2025
@chrisseto chrisseto force-pushed the backport/release/v2.3.x/pr-1138 branch from bda9c64 to c685e83 Compare October 27, 2025 20:08
@chrisseto chrisseto enabled auto-merge (rebase) October 27, 2025 20:46
@github-actions github-actions bot removed the stale label Oct 28, 2025
@RafalKorepta
Copy link
Contributor

RafalKorepta commented Oct 29, 2025

In v2.3.x the helm crds are missing. I wonder if we removed them in this release branch?

applying HelmRepository: the server could not find the requested resource (patch helmrepositories.source.toolkit.fluxcd.io redpanda-repository)
(1) attached stack trace
  -- stack trace:
  | github.com/redpanda-data/redpanda-operator/operator/internal/controller/redpanda.(*RedpandaReconciler).Reconcile
  | 	/work/operator/internal/controller/redpanda/redpanda_controller.go:253
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:114
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:311
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:261
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:222
Wraps: (2) attached stack trace
  -- stack trace:
  | github.com/redpanda-data/redpanda-operator/operator/internal/controller/redpanda.(*RedpandaReconciler).reconcileFlux
  | 	/work/operator/internal/controller/redpanda/redpanda_controller.go:874
  | [...repeated from below...]
Wraps: (3) applying HelmRepository
Wraps: (4) attached stack trace
  -- stack trace:
  | github.com/redpanda-data/redpanda-operator/operator/internal/controller/redpanda.(*RedpandaReconciler).apply
  | 	/work/operator/internal/controller/redpanda/redpanda_controller.go:1135
  | github.com/redpanda-data/redpanda-operator/operator/internal/controller/redpanda.(*RedpandaReconciler).reconcileHelmRepository
  | 	/work/operator/internal/controller/redpanda/redpanda_controller.go:943
  | github.com/redpanda-data/redpanda-operator/operator/internal/controller/redpanda.(*RedpandaReconciler).reconcileFlux
  | 	/work/operator/internal/controller/redpanda/redpanda_controller.go:873
  | github.com/redpanda-data/redpanda-operator/operator/internal/controller/redpanda.(*RedpandaReconciler).Reconcile
  | 	/work/operator/internal/controller/redpanda/redpanda_controller.go:251
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:114
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:311
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:261
  | sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
  | 	/root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:222
  | runtime.goexit
  | 	/nix/store/02kl9hh07rl3iyvsdrcrhgq7xzi0wf2w-go-1.23.8/share/go/src/runtime/asm_amd64.s:1700
Wraps: (5) the server could not find the requested resource (patch helmrepositories.source.toolkit.fluxcd.io redpanda-repository)
Error types: (1) *withstack.withStack (2) *withstack.withStack (3) *fmt.wrapError (4) *withstack.withStack (5) *errors.StatusError

@chrisseto chrisseto force-pushed the backport/release/v2.3.x/pr-1138 branch from c685e83 to c76a001 Compare November 3, 2025 16:36
@chrisseto
operator: various sidecar fixes
5ede0f2 
Prior to this commit the operator sidecar's decommissioner and pvcunbinder
controllers did not work. This was due to:
- RBAC issues, the sidecar did not correctly scope itself to a single namespace.
- Incorrect label selectors hidden within the controllers in question.

Additionally, the statefulset decommissioner's sole test case has been disabled
for quite sometime. There's been zero test coverage of this functionality.

This commit:
- Restores the decommissioner's tests to a working state
- Strips out the "fetcher" to reduce duplication and remove reliance on
  fetching live helm values.
- Replaces baked in filtering with a label selector argument that will be
  constructed by the helm chart.

A follow up commit with chart changes and acceptance tests will be submitted.
It's been made separate to ease the process of backporting to the v2.x.x
branches.

(cherry picked from commit 03dd394)

# Conflicts:
#	operator/cmd/run/run.go
#	operator/go.mod
#	pkg/go.mod
@chrisseto chrisseto force-pushed the backport/release/v2.3.x/pr-1138 branch from c76a001 to 5ede0f2 Compare November 4, 2025 19:39
@chrisseto chrisseto merged commit b702e7d into release/v2.3.x Nov 4, 2025
11 checks passed
@chrisseto
Copy link
Contributor

chrisseto commented Nov 4, 2025

Looks like the issue with integration tests was resource exhaustion as this branch doesn't clean up k3d clusters https://github.com/redpanda-data/redpanda-operator/pull/1153/files#diff-5eb410ad78f978d15d3ebe3da3954bedf6e5a2436b022b010a9582331d367bbaR139-R148

@chrisseto chrisseto deleted the backport/release/v2.3.x/pr-1138 branch November 4, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisseto chrisseto chrisseto approved these changes

@RafalKorepta RafalKorepta Awaiting requested review from RafalKorepta RafalKorepta is a code owner

@andrewstucki andrewstucki Awaiting requested review from andrewstucki andrewstucki is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

Assignees

@chrisseto chrisseto

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RafalKorepta @chrisseto