[release/v25.1.x] feat(operator): implement role membership reconciliation (#1192) #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(operator): implement role membership reconciliation - Add ManagedPrincipals status field to track membership management - Update controller to reconcile membership changes (add/remove/clear) - Add ClearPrincipals method for transitioning to unmanaged mode - Add comprehensive unit tests for membership updates - Add acceptance tests for principals management scenarios Implements strict membership management where operator reconciles all members in spec. When spec.principals is empty/nil, operator stops managing membership (managedPrincipals=false). * chore: add changelog entry for role membership reconciliation * fix(acceptance): update test for always-manage-role pattern The operator always takes full ownership of roles it manages, regardless of whether they pre-existed. Updated the authorization-only test to expect role deletion when the CRD is removed. Also updated controller to set managedRole=true when managing pre-existing roles to ensure proper cleanup. (cherry picked from commit 7b1c1df) # Conflicts: # acceptance/features/role-crds.feature # acceptance/steps/register.go # acceptance/steps/roles.go # operator/api/applyconfiguration/redpanda/v1alpha2/rolestatus.go # operator/api/redpanda/v1alpha2/role_types.go # operator/api/redpanda/v1alpha2/testdata/crd-docs.adoc # operator/config/crd/bases/cluster.redpanda.com_redpandaroles.yaml # operator/internal/controller/redpanda/role_controller.go # operator/internal/controller/redpanda/role_controller_test.go # operator/pkg/client/roles/client.go
github-actions
bot
requested review from
andrewstucki,
chrisseto and
gene-redpanda
as code owners
Contributor
|
Back port is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease/v25.1.x:Questions ?
Please refer to the Backport tool documentation