Add supported secret scopes to Console CRD #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-sadura
requested review from
RafalKorepta,
andrewstucki and
chrisseto
as code owners
|
|
tomasz-sadura
force-pushed
the
ts/add-secret-scopes-to-console
branch
from
d979e53 to
283b92d
Compare
nicolaferraro
approved these changes
Nov 26, 2024
Member
nicolaferraro
left a comment
nicolaferraro
left a comment
There was a problem hiding this comment.
I assume that it maps directly to console config
tomasz-sadura
force-pushed
the
ts/add-secret-scopes-to-console
branch
from
283b92d to
1c66136
Compare
bojand
reviewed
Nov 26, 2024
| AWSSecretManager *SecretManagerAWS `json:"awsSecretManager,omitempty"` | ||
| KafkaConnect *SecretStoreKafkaConnect `json:"kafkaConnect,omitempty"` | ||
| // Scopes is a list of supported secret scopes | ||
| Scopes []string `json:"scopes,omitempty"` |
Contributor
There was a problem hiding this comment.
Should this be reconciled within genSecretStore() ?
tomasz-sadura
force-pushed
the
ts/add-secret-scopes-to-console
branch
from
1c66136 to
4d6312f
Compare
RafalKorepta
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.