Conversation
Prior to this commit, toggling useFlux from true <-> false would result in the bootstrap user's password being re-minted due to the chart gating the check for existing Secrets with `.Release.IsUpgrade` and the operator failing to set that field. This commit bumps the chart to a version that always runs the lookup check to correctly manage transitions to and from flux installations. Additionally, this commit includes an update to the operator's integration test suite which self hosts a helm repository if a replace directive targeting the redpanda helm chart is found in the go.mod. This makes it possible to test local changes of the helm chart in both flux and defluxed modes.
The task ci:test:acceptance target is creating kind cluster. The kind cluster created in test:acceptance inside Taskfile.yml is redundant.
Prior to this commit we utilized `goreleaser` to build the operator. It began producing errors when we started following go modules' tagging convention. As we'd like to be able to use go modules' tagging, this commit complete removes goreleaser in favor of a taskfile build matrix. This commit additional DRYs up the taskfile configs for building the operator image and sets a presedent to use `git describe` for determining the "version" of builds.
…ease branches This commit standardizes our builds to use `git describe` for minting version stamps and pushes all gating logic into buildkite's `if` clauses. The end result is 3 pipeline commands: 1. ci-entry-point - Our test suite. Runs on PRs, merges, and nightly schedules 2. release-nightly - Publishes nightly release. Runs on nightly schedules or manual triggers from the UI. 3. operator-release - Publishes operator releases to dockerhub. Runs when main or release/* is tagged with v* or operator/v* Modifications to the chart packaging code were made to allow local testing and verification of version stamping. (cherry picked from commit 054413d)
This commit drops `goimports` in favor of `gci` as goimports fails to reformat import blocks with extraneous `\n`s. For example, goimports considers this block valid. ```go import ( "net" "net/http" ) ``` `gci`, will reformat it to: ```go import ( "net" "net/http" ) ``` Additionally, this commit updates the `importas` linter with naming requirements for commonly used k8s packages.
Clean the kustomization. Remove unused kustomization `default-with-metrics`. Remove `kube-rbac-proxy` container from kustomization and helm chart. (cherry picked from commit dfebcbb)
Prior to this commit the redpanda chart would always append a `.` to the end of internal URIs. This is known to cause issues with librdkafka when using the internal listener with TLS enabled. This commit moves the trailing `.` to be part of the chart's default values rather than being baked into the chart's behavior which allows users to opt out by overriding `clusterDomain`. Fixes #400. Fixes redpanda-data/helm-charts#1497 K8S-483
- add flag to enable this new controller (it's previously only available as sidecar) - update factory to create admin api for v1 clusters - add log when decommissioning a broke
* Add dialer injection to v1 admin client initialization * Fix linter issues * Add dialer passthrough for cluster attached resources * Fix linter issues
Contributor
|
@birdayz can this be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.