[K8S-537] bind operator and operator chart versions#599
Merged
Conversation
Contributor
Author
|
Ah, I should also mention the RBAC config of the operator was impressively out of date. I also updated as part of the move as I changed our tests to point at the local kustomize configurations instead of a static version. |
8e7a097 to
b55a397
Compare
Contributor
|
Currently I see problems with RBAC |
Contributor
RafalKorepta
left a comment
There was a problem hiding this comment.
I found one Role didn't have RoleBinding. After my flight I will push fix
97b72c5 to
d5e3574
Compare
Prior to this commit the operator helm chart was managed as a standalone module/project. Doing so resulted in needless confusion and compatibility issues. This commit moves `charts/operator` to `operator/chart` and combines the go modules into one, effectively making the release and development process of the operator and its chart one in the same.
d5e3574 to
931cd12
Compare
Contributor
Author
I fixed up the role bindings. Acceptance and integration tests are passing locally for me. |
andrewstucki
approved these changes
Apr 3, 2025
This was referenced Apr 4, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit the operator helm chart was managed as a standalone module/project. Doing so resulted in needless confusion and compatibility issues.
This commit moves
charts/operatortooperator/chartand combines the go modules into one, effectively making the release and development process of the operator and its chart one in the same.