[release/v2.3.x] move pkg/secrets to operator/pkg/secrets

[alenkacz]

Backport

This will backport the following commits from main to release/v2.3.x:

• move pkg/secrets to operator/pkg/secrets

Questions ?

Please refer to the Backport tool documentation

[RafalKorepta]

Please bump to v0.1.3

Suggested change

	github.com/redpanda-data/common-go/secrets v0.1.2
	github.com/redpanda-data/common-go/secrets v0.1.3

per #651

[RafalKorepta]

https://buildkite.com/redpanda/redpanda-operator/builds/5514#01960ece-c4a3-4046-a000-c0b735dd56bf/195-1102

operator/cmd/configurator/bootstrap.go:11:2: could not import github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration (-: # github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration
--
  | pkg/clusterconfiguration/expander.go:20:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used) (typecheck)
  | "github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration"
  | ^
  | operator/cmd/configurator/bootstrap.go:12:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used (typecheck)
  | pkgsecrets "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets"
  | ^
  | operator/cmd/run/run.go:61:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used (typecheck)
  | pkgsecrets "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets"
  | ^
  | operator/internal/controller/vectorized/cluster_controller.go:461:2: declared and not used: pki (typecheck)
  | pki, err := ar.getPKI()
  | ^
  | operator/internal/controller/vectorized/cluster_controller.go:892:2: declared and not used: pki (typecheck)
  | pki, err := ar.getPKI()
  | ^
  | operator/internal/controller/vectorized/test/console_controller_test.go:320:5: declared and not used: rbacDataVal (typecheck)
  | rbacDataVal = `roleBindings:
  | ^
  | operator/pkg/clusterconfiguration/expander.go:1: : # github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration
  | pkg/clusterconfiguration/expander.go:20:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used (typecheck)
  | // Package clusterconfiguration holds types to track cluster configuration - the CRD declarations need to
  | operator/pkg/resources/configuration/configuration.go:27:2: could not import github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration (-: # github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration
  | pkg/clusterconfiguration/expander.go:20:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used) (typecheck)
  | "github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration"
  | ^
  | operator/pkg/resources/configuration/configuration.go:29:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used (typecheck)
  | pkgsecrets "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets"
  | ^
  | operator/pkg/resources/statefulset.go:41:2: could not import github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration (-: # github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration
  | pkg/clusterconfiguration/expander.go:20:2: "github.com/redpanda-data/redpanda-operator/operator/pkg/secrets" imported as pkgsecrets and not used) (typecheck)
  | "github.com/redpanda-data/redpanda-operator/operator/pkg/clusterconfiguration"
  | ^
  | 10 issues:
  | * typecheck: 10

I think the #625 should be merged first.

[RafalKorepta]

In my opinion it would be better to not create backports, but rather create bespoke PR that manually changes all required files for secret expander to work correctly.