remove concept of "external/internal" versions#667
Merged
Conversation
This commit removes all references and tooling relating to "internal/external"
versions also known as +k8s versions.
Due to the constraints of semver, which is strictly followed by both helm and
go, we can't add a k8s specific differentiator into our versions without losing
ordering properties or having all versions be considered prereleases.
The decision was to drop all notions thereof and standardize on
`v{APP_MAJOR}.{APP_MINOR}.{CHART_PATCH}` for charts and the operator alike.
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
andrewstucki
approved these changes
Apr 7, 2025
Contributor
Author
|
It'll be a bit nasty to do, but it'll likely be in our best interest to retag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes all references and tooling relating to "internal/external" versions also known as +k8s versions.
Due to the constraints of semver, which is strictly followed by both helm and go, we can't add a k8s specific differentiator into our versions without losing ordering properties or having all versions be considered prereleases.
The decision was to drop all notions thereof and standardize on
v{APP_MAJOR}.{APP_MINOR}.{CHART_PATCH}for charts and the operator alike.