operator/chart: remove unused KubeRBACProxy field#679
Merged
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
andrewstucki
approved these changes
Apr 8, 2025
Contributor
andrewstucki
left a comment
andrewstucki
left a comment
There was a problem hiding this comment.
I'll approve this even though you'll need to fix up the tests due to closing the schema 😅
Contributor
Author
|
Yeah, I'll get back to this for the next round of patch releases. This is a nice to have, if anything. |
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
chrisseto
force-pushed
the
chris/p/operator-remove-rbac-proxy
branch
from
c7f2e17 to
68e9a4e
Compare
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Kube RBAC Proxy was removed in a previous commit but the field in the values struct was left behind. This commit removes the leftover field.
chrisseto
force-pushed
the
chris/p/operator-remove-rbac-proxy
branch
from
68e9a4e to
f9a038e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kube RBAC Proxy was removed in a previous commit but the field in the values struct was left behind. This commit removes the leftover field.