Skip to content

operator: correct rack awareness permissions#899

Merged
chrisseto merged 1 commit intomainfrom
chris/p/k8s-623-fix-rackawareness
Jun 10, 2025
Merged

operator: correct rack awareness permissions#899
chrisseto merged 1 commit intomainfrom
chris/p/k8s-623-fix-rackawareness

Conversation

@chrisseto
Copy link
Contributor

Prior to this commit the operator's chart incorrect referenced a non-existent Role for the permissions of rack awareness. As helm loves to swallow errors, this went unnoticed until reported by an end user.

This commit corrects the mistake and adds a regression acceptance test.

Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Prior to this commit the operator's chart incorrect referenced a non-existent
`Role` for the permissions of rack awareness. As helm loves to swallow errors,
this went unnoticed until reported by an end user.

This commit corrects the mistake and adds a regression acceptance test.
@RafalKorepta RafalKorepta force-pushed the chris/p/k8s-623-fix-rackawareness branch from 3725c60 to de0aa5c Compare June 10, 2025 10:32
@chrisseto chrisseto merged commit 518ce34 into main Jun 10, 2025
10 checks passed
@RafalKorepta RafalKorepta deleted the chris/p/k8s-623-fix-rackawareness branch June 10, 2025 13:41
@chrisseto
Copy link
Contributor Author

💔 Some backports could not be created

Status Branch Result
release/v25.1.x An unhandled error occurred. Please see the logs for details
release/v2.4.x
release/v2.3.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 899

Questions ?

Please refer to the Backport tool documentation

@chrisseto
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
release/v25.1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants