operator: add golden style tests to the V1 operator#910
Closed
operator: add golden style tests to the V1 operator#910
Conversation
This commit improves the ergonomics of the kube.Ctl struct by allowing configuration with variadic options and implementing Apply. These improvements have been carried over to the kubetest.NewEnv function as well. Most notably, this allows specifying the Scheme of the testenv which makes it useable when testing CRDs.
| } | ||
|
|
||
| select { | ||
| case <-time.After(10 * time.Second): |
Contributor
There was a problem hiding this comment.
NIT: Should this be configurable?
Comment on lines
+202
to
+203
| const logEvery = 10 * time.Second | ||
| const timeout = 5 * time.Minute |
Contributor
There was a problem hiding this comment.
NIT: Should this be configurable?
chrisseto
force-pushed
the
chris/p/v1-ctrl-golden-tests
branch
from
334115c to
be13597
Compare
|
This PR is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Contributor
Author
|
Closing this as it's commits have been split between: Thanks for looking Rafal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ended up being a bit nastier than I expected but it's mostly working. Just needs to have the actual golden files written out.