Skip to content

Commit 0d99276

Browse files
authored
Merge pull request #29040 from redpanda-data/kb/docs/proto/patch-descriptions
Improve descriptions for OpenAPI (backport)
2 parents 28c7801 + 3bc6fde commit 0d99276

File tree

4 files changed

+83
-10
lines changed

4 files changed

+83
-10
lines changed

proto/redpanda/core/admin/v2/broker.proto

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,17 @@ option (pbgen.cpp_namespace) = "proto::admin";
2424
// The BrokerService gives information about individual brokers within the
2525
// cluster.
2626
service BrokerService {
27-
// GetBroker returns information about a single broker in the cluster.
27+
// GetBroker
28+
//
29+
// Returns information about a single broker in the cluster.
2830
rpc GetBroker(GetBrokerRequest) returns (GetBrokerResponse) {
2931
option (pbgen.rpc) = {
3032
authz: SUPERUSER
3133
};
3234
}
33-
// ListBrokers returns information about all brokers in the cluster.
35+
// ListBrokers
36+
//
37+
// Returns information about all brokers in the cluster.
3438
rpc ListBrokers(ListBrokersRequest) returns (ListBrokersResponse) {
3539
option (pbgen.rpc) = {
3640
authz: SUPERUSER

proto/redpanda/core/admin/v2/cluster.proto

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@ option (pbgen.cpp_namespace) = "proto::admin";
2424

2525
// The ClusterService gives information about the cluster.
2626
service ClusterService {
27-
// ListKafkaConnections returns information about the cluster's Kafka
28-
// connections, collected and ordered across all brokers.
27+
// ListKafkaConnections
28+
//
29+
// Returns information about the cluster's Kafka connections, collected
30+
// and ordered across all brokers.
2931
rpc ListKafkaConnections(ListKafkaConnectionsRequest)
3032
returns (ListKafkaConnectionsResponse) {
3133
option (pbgen.rpc) = {

proto/redpanda/core/admin/v2/shadow_link.proto

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,53 +30,74 @@ import "google/protobuf/field_mask.proto";
3030
option (pbgen.cpp_namespace) = "proto::admin";
3131

3232
service ShadowLinkService {
33+
// CreateShadowLink
34+
//
35+
// Creates a new shadow link between clusters.
3336
rpc CreateShadowLink(CreateShadowLinkRequest)
3437
returns (CreateShadowLinkResponse) {
3538
option (pbgen.rpc) = {
3639
authz: SUPERUSER
3740
};
3841
}
42+
// DeleteShadowLink
43+
//
44+
// Deletes an existing shadow link.
3945
rpc DeleteShadowLink(DeleteShadowLinkRequest)
4046
returns (DeleteShadowLinkResponse) {
4147
option (pbgen.rpc) = {
4248
authz: SUPERUSER
4349
};
4450
}
51+
// GetShadowLink
52+
//
53+
// Gets information about a specific shadow link.
4554
rpc GetShadowLink(GetShadowLinkRequest) returns (GetShadowLinkResponse) {
4655
option (pbgen.rpc) = {
4756
authz: SUPERUSER
4857
};
4958
}
59+
// ListShadowLinks
60+
//
61+
// Lists all shadow links in the cluster.
5062
rpc ListShadowLinks(ListShadowLinksRequest)
5163
returns (ListShadowLinksResponse) {
5264
option (pbgen.rpc) = {
5365
authz: SUPERUSER
5466
};
5567
}
68+
// UpdateShadowLink
69+
//
70+
// Updates an existing shadow link configuration.
5671
rpc UpdateShadowLink(UpdateShadowLinkRequest)
5772
returns (UpdateShadowLinkResponse) {
5873
option (pbgen.rpc) = {
5974
authz: SUPERUSER
6075
};
6176
}
62-
// Fails over a shadow link or a single shadow topic
77+
// FailOver
78+
//
79+
// Fails over a shadow link or a single shadow topic for disaster recovery.
6380
rpc FailOver(FailOverRequest) returns (FailOverResponse) {
6481
option (pbgen.rpc) = {
6582
authz: SUPERUSER
6683
};
6784
}
6885

69-
// This operation returns information about a Shadow Topic on a Shadow Link.
70-
// A Shadow Topic is a resource created automatically by a Shadow Link. The
71-
// Shadow Topic 'shadows' a topic on a source cluster, mirroring the data
86+
// GetShadowTopic
87+
//
88+
// Returns information about a shadow topic on a shadow link.
89+
// A shadow topic is a resource created automatically by a shadow link. The
90+
// shadow topic 'shadows' a topic on a source cluster, mirroring the data
7291
// and properties of that topic.
7392
rpc GetShadowTopic(GetShadowTopicRequest) returns (GetShadowTopicResponse) {
7493
option (pbgen.rpc) = {
7594
authz: SUPERUSER
7695
};
7796
}
78-
// This operation returns a list of all Shadow Topics on a Shadow Link and
79-
// their status
97+
// ListShadowTopics
98+
//
99+
// Returns a list of all shadow topics on a shadow link and
100+
// their status.
80101
rpc ListShadowTopics(ListShadowTopicsRequest)
81102
returns (ListShadowTopicsResponse) {
82103
option (pbgen.rpc) = {

proto/redpanda/core/pbgen/comments.pb.go

Lines changed: 46 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)