Skip to content

Commit 823ae0d

Browse files
authored
Merge pull request #29575 from IoannisRP/CORE-15501/large-alloc-kclient
[CORE-15501] kafka/client: replace circular buffer with chunked equivalent
2 parents 32a2523 + 355d5a1 commit 823ae0d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/v/kafka/client/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ redpanda_cc_library(
326326
"//src/v/bytes:iostream",
327327
"//src/v/bytes:scattered_message",
328328
"//src/v/config",
329+
"//src/v/container:chunked_circular_buffer",
329330
"//src/v/container:chunked_hash_map",
330331
"//src/v/container:chunked_vector",
331332
"//src/v/hashing:murmur",

src/v/kafka/client/produce_batcher.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313

1414
#include "absl/container/flat_hash_map.h"
1515
#include "base/seastarx.h"
16+
#include "container/chunked_circular_buffer.h"
1617
#include "kafka/protocol/produce.h"
1718
#include "model/fundamental.h"
1819
#include "storage/record_batch_builder.h"
1920

20-
#include <seastar/core/circular_buffer.hh>
2121
#include <seastar/core/coroutine.hh>
2222

2323
namespace kafka::client {
@@ -124,8 +124,8 @@ class produce_batcher {
124124
model::compression _c;
125125
storage::record_batch_builder _builder;
126126
// TODO(Ben): Maybe these should be a queue for backpressure
127-
ss::circular_buffer<client_context> _client_reqs;
128-
ss::circular_buffer<broker_context> _broker_reqs;
127+
chunked_circular_buffer<client_context> _client_reqs;
128+
chunked_circular_buffer<broker_context> _broker_reqs;
129129
};
130130

131131
} // namespace kafka::client

0 commit comments

Comments
 (0)