Merge pull request #28807 from michael-redpanda/sl/alias-prefix

proto: Alias prefix and prefixed

Author: michael-redpanda

.github/workflows/buf.yml

@@ -50,7 +50,7 @@ jobs:
           paths: proto
           lint: true
           format: false  # We use clang-tidy
-          breaking: false  # flip to true when we have a release
+          breaking: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'buf skip breaking') }} # Enable breaking change check unless the label 'buf skip breaking' is set
           push: false  # Only validate, don't push to registry
   # ===========================================================================
   # Job: push-to-registry (push events only - registry operations only)

buf.yaml

@@ -29,6 +29,9 @@ lint:
     # it to be easy to write.
     ENUM_VALUE_PREFIX:
       - proto/redpanda/core/pbgen
+    ENUM_NO_ALLOW_ALIAS:
+      - proto/redpanda/core/admin/v2/shadow_link.proto
+      - proto/redpanda/core/common/v1/acl.proto
 breaking:
   use:
     - FILE

proto/redpanda/core/admin/v2/shadow_link.proto

@@ -570,11 +570,14 @@ enum ScramMechanism {
 }
 // The matching pattern type
 enum PatternType {
+    option allow_alias = true;
     PATTERN_TYPE_UNSPECIFIED = 0;
     // Must match the filter exactly
     PATTERN_TYPE_LITERAL = 1;
     // Will match anything that starts with filter
     PATTERN_TYPE_PREFIX = 2;
+    // Will match anything that starts with filter
+    PATTERN_TYPE_PREFIXED = 2;
 }
 // What type of filter this is, include or exclude
 enum FilterType {

proto/redpanda/core/common/v1/acl.proto

@@ -42,13 +42,16 @@ enum ACLResource {
 }
 // The ACL pattern type
 enum ACLPattern {
+    option allow_alias = true;
     ACL_PATTERN_UNSPECIFIED = 0;
     // Wildcard to match any pattern
     ACL_PATTERN_ANY = 1;
     // Match a literal string
     ACL_PATTERN_LITERAL = 2;
     // Match a prefix
     ACL_PATTERN_PREFIXED = 3;
+    // Match a prefix
+    ACL_PATTERN_PREFIX = 3;
     // Match serves as a catch-all for all the names of a topic
     // the principal is authorized to access
     ACL_PATTERN_MATCH = 4;