Skip to content

Commit cfab6da

Browse files
committed
Image fixes and select_image eye candy. ;)
1 parent 4ce2b2e commit cfab6da

File tree

13 files changed

+38
-19
lines changed

13 files changed

+38
-19
lines changed

ReduxCore/assets/css/admin.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ReduxCore/assets/css/admin.less

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,6 @@ a {
317317
border-bottom: 1px solid #E7E7E7;
318318
}
319319
.redux-group-tab .redux-section-desc{
320-
font-size:1.1em;
321320
margin-bottom: 35px;
322321
color:#666666;
323322
}
@@ -337,7 +336,6 @@ a {
337336
}
338337
.redux-group-tab .form-table tr th{
339338
font-weight:bold;
340-
font-size:1.1em;
341339
width:30%;
342340
padding:20px 5px 20px 0px;
343341
}
@@ -959,6 +957,7 @@ img {
959957

960958
.redux-main .field-desc {
961959
clear: both;
960+
font-size: 13px;
962961
}
963962

964963
.redux-main .data-full li{

ReduxCore/assets/css/redux.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ReduxCore/assets/js/redux.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ReduxCore/extensions/edd/edd_license/field_edd_license.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ReduxCore/inc/fields/image_select/field_image_select.css

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,15 @@
44
.redux-container-image_select .redux-image-select-presets img {
55
width: 100%;
66
}
7-
.redux-container-image_select .redux-image-select {
8-
margin: 3px 10px;
7+
.redux-container-image_select ul.redux-image-select li {
8+
margin: 0 10px 3px 10px;
99
display: inline-block;
1010
padding: 10px;
1111
padding-left: 0;
1212
}
13+
.redux-container-image_select .redux-image-select li:last-child {
14+
margin-bottom: 0;
15+
}
1316
.redux-container-image_select .redux-image-select-selected {
1417
background-color: #f9f9f9;
1518
}

ReduxCore/inc/fields/image_select/field_image_select.less

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,15 @@
55
.redux-image-select-presets img {
66
width: 100%;
77
}
8-
.redux-image-select {
9-
margin:3px 10px;
8+
ul.redux-image-select li {
9+
margin: 0 10px 3px 10px;
1010
display:inline-block;
1111
padding:10px;
1212
padding-left: 0;
1313
}
14+
.redux-image-select li:last-child {
15+
margin-bottom: 0;
16+
}
1417
.redux-image-select-selected{
1518
background-color:#f9f9f9;
1619
}
Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
1-
function updateSelectImage(obj, imgID) {
2-
tochange = obj.value;
3-
document.getElementById(imgID).src = tochange;
4-
document.getElementById(imgID).style = 'visibility:show;';
5-
}
1+
(function($){
2+
3+
$('.redux-select-image-item').on('change', function() {
4+
var preview = $(this).parents('.redux-field:first').find('.redux-preview-image');
5+
if ($(this).val() === "") {
6+
preview.fadeOut('medium', function() {
7+
preview.attr('src', '');
8+
});
9+
} else {
10+
preview.attr('src', $(this).val());
11+
preview.fadeIn();
12+
}
13+
});
14+
15+
})(jQuery);
16+
17+

ReduxCore/inc/fields/select_image/field_select_image.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function render() {
5959
$placeholder = (isset($this->field['placeholder'])) ? esc_attr($this->field['placeholder']) : __('Select an item', 'redux-framework');
6060

6161
// Begin the <select> tag
62-
echo '<select id="' . $this->field['id'] . '-select_image" data-placeholder="' . $placeholder . '" name="' . $this->args['opt_name'] . '[' . $this->field['id'] . ']" class="redux-select-item ' . $this->field['class'] . '"' . $width . ' rows="6"' . 'onchange="updateSelectImage(this, \'image_' . $this->field['id'] . '\');">';
62+
echo '<select id="' . $this->field['id'] . '-select_image" data-placeholder="' . $placeholder . '" name="' . $this->args['opt_name'] . '[' . $this->field['id'] . ']" class="redux-select-item redux-select-image-item ' . $this->field['class'] . '"' . $width . ' rows="6"' . '>';
6363
echo '<option></option>';
6464

6565

ReduxCore/inc/fields/slides/field_slides.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
float: right;
5252
margin-right: 10%;
5353
display: block;
54+
margin-bottom: 10px;
5455
}
5556
.redux-container-slides .redux-slides-remove {
5657
color: #ef521d !important;

0 commit comments

Comments
 (0)