Skip to content

Commit 0aababf

Browse files
aryaemami59markerikson
authored andcommitted
Set @types/react and @types/react-dom to temporary types packages
- We set the `@types/react` and `@types/react-dom` package resolutions to `npm:types-react` and `npm:types-react-dom` according to the React 19 migration guide.
1 parent ad9af11 commit 0aababf

File tree

3 files changed

+39
-13
lines changed

3 files changed

+39
-13
lines changed

.github/workflows/test.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,19 @@ jobs:
4747
matrix:
4848
node: ['20.x']
4949
ts: ['4.7', '4.8', '4.9', '5.0', '5.1', '5.2', '5.3', '5.4', '5.5']
50+
react:
51+
[
52+
{
53+
version: '^18',
54+
types: ^18,
55+
react-dom: { version: '^18', types: '^18' },
56+
},
57+
{
58+
version: 'rc',
59+
types: 'npm:types-react@rc',
60+
react-dom: { version: 'rc', types: 'npm:types-react-dom@rc' },
61+
},
62+
]
5063

5164
steps:
5265
- name: Checkout repo
@@ -237,6 +250,20 @@ jobs:
237250
fail-fast: false
238251
matrix:
239252
node: ['20.x']
253+
react:
254+
[
255+
{
256+
version: '^18',
257+
types: ^18,
258+
react-dom: { version: '^18', types: '^18' },
259+
},
260+
{
261+
version: 'rc',
262+
types: 'npm:types-react@rc',
263+
react-dom: { version: 'rc', types: 'npm:types-react-dom@rc' },
264+
},
265+
]
266+
240267
steps:
241268
- name: Checkout repo
242269
uses: actions/checkout@v4

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@
8585
"@testing-library/react": "^16.0.0",
8686
"@types/node": "^20.14.2",
8787
"@types/prop-types": "^15.7.12",
88-
"@types/react": "18.3.3",
89-
"@types/react-dom": "^18.3.0",
88+
"@types/react": "npm:types-react@rc",
89+
"@types/react-dom": "npm:types-react-dom@rc",
9090
"babel-eslint": "^10.1.0",
9191
"codecov": "^3.8.3",
9292
"cross-env": "^7.0.3",

yarn.lock

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2234,12 +2234,12 @@ __metadata:
22342234
languageName: node
22352235
linkType: hard
22362236

2237-
"@types/react-dom@npm:^18.3.0":
2238-
version: 18.3.1
2239-
resolution: "@types/react-dom@npm:18.3.1"
2237+
"@types/react-dom@npm:types-react-dom@rc":
2238+
version: 19.0.0-rc.1
2239+
resolution: "types-react-dom@npm:19.0.0-rc.1"
22402240
dependencies:
22412241
"@types/react": "npm:*"
2242-
checksum: 10/33f9ba79b26641ddf00a8699c30066b7e3573ab254e97475bf08f82fab83a6d3ce8d4ebad86afeb49bb8df3374390a9ba93125cece33badc4b3e8f7eac3c84d8
2242+
checksum: 10/fca4e7565308a109d4b126e5c7f5c387789a0187c9a46cb2a5af6120a7014beaa05736841be0ae658c7115871088500ddb0ef0bce60a21af4ec899cee8bb3c75
22432243
languageName: node
22442244
linkType: hard
22452245

@@ -2253,13 +2253,12 @@ __metadata:
22532253
languageName: node
22542254
linkType: hard
22552255

2256-
"@types/react@npm:18.3.3":
2257-
version: 18.3.3
2258-
resolution: "@types/react@npm:18.3.3"
2256+
"@types/react@npm:types-react@rc":
2257+
version: 19.0.0-rc.1
2258+
resolution: "types-react@npm:19.0.0-rc.1"
22592259
dependencies:
2260-
"@types/prop-types": "npm:*"
22612260
csstype: "npm:^3.0.2"
2262-
checksum: 10/68e203b7f1f91d6cf21f33fc7af9d6d228035a26c83f514981e54aa3da695d0ec6af10c277c6336de1dd76c4adbe9563f3a21f80c4462000f41e5f370b46e96c
2261+
checksum: 10/342da9ffeab93600a0cff4c8829e5350d935577e3f81bce7ead41d7cd074035e2c4a4bdd976fa8e3f5390fe6a32169370a805291a88a77c2f2ce2613bde54587
22632262
languageName: node
22642263
linkType: hard
22652264

@@ -6153,8 +6152,8 @@ __metadata:
61536152
"@testing-library/react": "npm:^16.0.0"
61546153
"@types/node": "npm:^20.14.2"
61556154
"@types/prop-types": "npm:^15.7.12"
6156-
"@types/react": "npm:18.3.3"
6157-
"@types/react-dom": "npm:^18.3.0"
6155+
"@types/react": "npm:types-react@rc"
6156+
"@types/react-dom": "npm:types-react-dom@rc"
61586157
"@types/use-sync-external-store": "npm:^0.0.6"
61596158
babel-eslint: "npm:^10.1.0"
61606159
codecov: "npm:^3.8.3"

0 commit comments

Comments
 (0)