Merge pull request #232 from skovhus/port-redux-sanity-check

Add error on undefined action type

Author: gaearon

src/instrument.js

@@ -16,6 +16,12 @@ export const ActionTypes = {
  */
 export const ActionCreators = {
   performAction(action) {
+    if (typeof action.type === 'undefined') {
+      throw new Error(
+        'Actions may not have an undefined "type" property. ' +
+        'Have you misspelled a constant?'
+      );
+    }
     return { type: ActionTypes.PERFORM_ACTION, action, timestamp: Date.now() };
   },
 

test/instrument.spec.js

@@ -176,6 +176,14 @@ describe('instrument', () => {
     spy.restore();
   });
 
+  it('should catch invalid action type', () => {
+    expect(() => {
+      store.dispatch({ type: undefined });
+    }).toThrow(
+      /Actions may not have an undefined/
+    );
+  });
+
   it('should return the last non-undefined state from getState', () => {
     let storeWithBug = instrument()(createStore)(counterWithBug);
     storeWithBug.dispatch({ type: 'INCREMENT' });