Fix issues related to spies and stubbing environments in utils.spec.ts

Author: aryaemami59

packages/toolkit/src/entities/tests/utils.spec.ts

@@ -1,66 +1,72 @@
-import { vi } from 'vitest'
+import { noop } from '@internal/listenerMiddleware/utils'
 import { AClockworkOrange } from './fixtures/book'
 
 describe('Entity utils', () => {
   describe(`selectIdValue()`, () => {
-    const OLD_ENV = process.env
+    const consoleWarnSpy = vi.spyOn(console, 'warn').mockImplementation(noop)
 
     beforeEach(() => {
       vi.resetModules() // this is important - it clears the cache
-      process.env = { ...OLD_ENV, NODE_ENV: 'development' }
+      vi.stubEnv('NODE_ENV', 'development')
     })
 
     afterEach(() => {
-      process.env = OLD_ENV
+      consoleWarnSpy.mockClear()
+      vi.unstubAllEnvs()
       vi.resetAllMocks()
     })
 
+    afterAll(() => {
+      consoleWarnSpy.mockRestore()
+    })
+
     it('should not warn when key does exist', async () => {
       const { selectIdValue } = await import('../utils')
-      const spy = vi.spyOn(console, 'warn')
 
       selectIdValue(AClockworkOrange, (book: any) => book.id)
-      expect(spy).not.toHaveBeenCalled()
+      expect(consoleWarnSpy).not.toHaveBeenCalled()
     })
 
     it('should warn when key does not exist in dev mode', async () => {
       const { selectIdValue } = await import('../utils')
-      const spy = vi.spyOn(console, 'warn')
+
+      expect(process.env.NODE_ENV).toBe('development')
 
       selectIdValue(AClockworkOrange, (book: any) => book.foo)
 
-      expect(spy).toHaveBeenCalled()
+      expect(consoleWarnSpy).toHaveBeenCalledOnce()
     })
 
     it('should warn when key is undefined in dev mode', async () => {
       const { selectIdValue } = await import('../utils')
-      const spy = vi.spyOn(console, 'warn')
+
+      expect(process.env.NODE_ENV).toBe('development')
 
       const undefinedAClockworkOrange = { ...AClockworkOrange, id: undefined }
       selectIdValue(undefinedAClockworkOrange, (book: any) => book.id)
 
-      expect(spy).toHaveBeenCalled()
+      expect(consoleWarnSpy).toHaveBeenCalledOnce()
     })
 
     it('should not warn when key does not exist in prod mode', async () => {
-      process.env.NODE_ENV = 'production'
+      vi.stubEnv('NODE_ENV', 'production')
+
       const { selectIdValue } = await import('../utils')
-      const spy = vi.spyOn(console, 'warn')
 
       selectIdValue(AClockworkOrange, (book: any) => book.foo)
 
-      expect(spy).not.toHaveBeenCalled()
+      expect(consoleWarnSpy).not.toHaveBeenCalled()
     })
 
     it('should not warn when key is undefined in prod mode', async () => {
-      process.env.NODE_ENV = 'production'
+      vi.stubEnv('NODE_ENV', 'production')
+
       const { selectIdValue } = await import('../utils')
-      const spy = vi.spyOn(console, 'warn')
 
       const undefinedAClockworkOrange = { ...AClockworkOrange, id: undefined }
       selectIdValue(undefinedAClockworkOrange, (book: any) => book.id)
 
-      expect(spy).not.toHaveBeenCalled()
+      expect(consoleWarnSpy).not.toHaveBeenCalled()
     })
   })
 })