Fix console spy related issues in injectEndpoints.test.tsx

Author: aryaemami59

packages/toolkit/src/query/tests/injectEndpoints.test.tsx

@@ -1,13 +1,24 @@
+import { noop } from '@internal/listenerMiddleware/utils'
 import { createApi, fetchBaseQuery } from '@reduxjs/toolkit/query'
-import { vi } from 'vitest'
 
 const api = createApi({
   baseQuery: fetchBaseQuery({ baseUrl: 'https://example.com' }),
   endpoints: () => ({}),
 })
 
 describe('injectEndpoints', () => {
-  test("query: overridding with `overrideEndpoints`='throw' throws an error", async () => {
+  const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(noop)
+
+  afterEach(() => {
+    consoleErrorSpy.mockClear()
+  })
+
+  afterAll(() => {
+    consoleErrorSpy.mockRestore()
+    vi.unstubAllEnvs()
+  })
+
+  test("query: overriding with `overrideEndpoints`='throw' throws an error", async () => {
     const extended = api.injectEndpoints({
       endpoints: (build) => ({
         injected: build.query<unknown, string>({
@@ -32,10 +43,8 @@ describe('injectEndpoints', () => {
     )
   })
 
-  test('query: overridding an endpoint with `overrideEndpoints`=false does nothing in production', async () => {
-    const consoleMock = vi.spyOn(console, 'error').mockImplementation(() => {})
-
-    process.env.NODE_ENV = 'development'
+  test('query: overriding an endpoint with `overrideEndpoints`=false does nothing in production', async () => {
+    vi.stubEnv('NODE_ENV', 'development')
 
     const extended = api.injectEndpoints({
       endpoints: (build) => ({
@@ -54,15 +63,13 @@ describe('injectEndpoints', () => {
       }),
     })
 
-    expect(consoleMock).toHaveBeenCalledWith(
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
       `called \`injectEndpoints\` to override already-existing endpointName injected without specifying \`overrideExisting: true\``,
     )
   })
 
-  test('query: overridding with `overrideEndpoints`=false logs an error in development', async () => {
-    const consoleMock = vi.spyOn(console, 'error').mockImplementation(() => {})
-
-    process.env.NODE_ENV = 'production'
+  test('query: overriding with `overrideEndpoints`=false logs an error in development', async () => {
+    vi.stubEnv('NODE_ENV', 'production')
 
     const extended = api.injectEndpoints({
       endpoints: (build) => ({
@@ -81,6 +88,6 @@ describe('injectEndpoints', () => {
       }),
     })
 
-    expect(consoleMock).not.toHaveBeenCalled()
+    expect(consoleErrorSpy).not.toHaveBeenCalled()
   })
 })