Remove unused ESLint disable directives

Author: aryaemami59

packages/toolkit/src/createAsyncThunk.ts

@@ -61,7 +61,7 @@ export interface SerializedError {
   code?: string
 }
 
-const commonProperties: Array<keyof SerializedError> = [
+const commonProperties: (keyof SerializedError)[] = [
   'name',
   'message',
   'stack',
@@ -606,7 +606,6 @@ export const createAsyncThunk = /* @__PURE__ */ (() => {
             }
 
             if (conditionResult === false || abortController.signal.aborted) {
-              // eslint-disable-next-line no-throw-literal
               throw {
                 name: 'ConditionError',
                 message: 'Aborted due to condition callback returning false.',

packages/toolkit/src/createSlice.ts

@@ -110,7 +110,7 @@ export interface Slice<
    * Equivalent to `slice.getSelectors((state: RootState) => state[slice.reducerPath])`.
    */
   get selectors(): Id<
-    SliceDefinedSelectors<State, Selectors, { [K in ReducerPath]: State }>
+    SliceDefinedSelectors<State, Selectors, Record<ReducerPath, State>>
   >
 
   /**
@@ -132,7 +132,7 @@ export interface Slice<
    *
    * Will throw an error if slice is not found.
    */
-  selectSlice(state: { [K in ReducerPath]: State }): State
+  selectSlice(state: Record<ReducerPath, State>): State
 }
 
 /**
@@ -171,7 +171,7 @@ type InjectedSlice<
     SliceDefinedSelectors<
       State,
       Selectors,
-      { [K in ReducerPath]?: State | undefined }
+      Partial<Record<ReducerPath, State | undefined>>
     >
   >
 
@@ -180,7 +180,7 @@ type InjectedSlice<
    *
    * Returns initial state if slice is not found.
    */
-  selectSlice(state: { [K in ReducerPath]?: State | undefined }): State
+  selectSlice(state: Partial<Record<ReducerPath, State | undefined>>): State
 }
 
 /**
@@ -437,9 +437,10 @@ export type SliceCaseReducers<State> =
 /**
  * The type describing a slice's `selectors` option.
  */
-export type SliceSelectors<State> = {
-  [K: string]: (sliceState: State, ...args: any[]) => any
-}
+export type SliceSelectors<State> = Record<
+  string,
+  (sliceState: State, ...args: any[]) => any
+>
 
 type SliceActionType<
   SliceName extends string,
@@ -759,7 +760,7 @@ export function buildCreateSlice({ creators }: BuildCreateSliceConfig = {}) {
       Slice<State, CaseReducers, Name, CurrentReducerPath, Selectors>,
       'getSelectors' | 'selectors' | 'selectSlice' | 'reducerPath'
     > {
-      function selectSlice(state: { [K in CurrentReducerPath]: State }) {
+      function selectSlice(state: Record<CurrentReducerPath, State>) {
         let sliceState = state[reducerPath]
         if (typeof sliceState === 'undefined') {
           if (injected) {

packages/toolkit/src/entities/tests/sorted_state_adapter.test.ts

@@ -21,7 +21,6 @@ describe('Sorted State Adapter', () => {
   let state: EntityState<BookModel, string>
 
   beforeAll(() => {
-    //eslint-disable-next-line
     Object.defineProperty(Array.prototype, 'unwantedField', {
       enumerable: true,
       configurable: true,

packages/toolkit/src/entities/tests/unsorted_state_adapter.test.ts

@@ -1,20 +1,19 @@
-import type { EntityAdapter, EntityState } from '../models'
+import { createNextState } from '../..'
 import { createEntityAdapter } from '../create_adapter'
+import type { EntityAdapter, EntityState } from '../models'
 import type { BookModel } from './fixtures/book'
 import {
   AClockworkOrange,
   AnimalFarm,
   TheGreatGatsby,
   TheHobbit,
 } from './fixtures/book'
-import { createNextState } from '../..'
 
 describe('Unsorted State Adapter', () => {
   let adapter: EntityAdapter<BookModel, string>
   let state: EntityState<BookModel, string>
 
   beforeAll(() => {
-    //eslint-disable-next-line
     Object.defineProperty(Array.prototype, 'unwantedField', {
       enumerable: true,
       configurable: true,
@@ -272,9 +271,9 @@ describe('Unsorted State Adapter', () => {
         entities: { b: { id: 'b', title: 'First' }, c: { id: 'c' } }
       }
       We now expect that only 'c' will be left:
-      { 
-        ids: [ 'c' ], 
-        entities: { c: { id: 'c', title: 'First' } } 
+      {
+        ids: [ 'c' ],
+        entities: { c: { id: 'c', title: 'First' } }
       }
     */
     expect(ids.length).toBe(1)

packages/toolkit/src/entities/unsorted_state_adapter.ts

@@ -102,7 +102,7 @@ export function createUnsortedStateAdapter<T, Id extends EntityId>(
   }
 
   function takeNewKey(
-    keys: { [id: string]: Id },
+    keys: Record<string, Id>,
     update: Update<T, Id>,
     state: R,
   ): boolean {
@@ -129,12 +129,12 @@ export function createUnsortedStateAdapter<T, Id extends EntityId>(
   }
 
   function updateManyMutably(
-    updates: ReadonlyArray<Update<T, Id>>,
+    updates: readonly Update<T, Id>[],
     state: R,
   ): void {
-    const newKeys: { [id: string]: Id } = {}
+    const newKeys: Record<string, Id> = {}
 
-    const updatesPerEntity: { [id: string]: Update<T, Id> } = {}
+    const updatesPerEntity: Record<string, Update<T, Id>> = {}
 
     updates.forEach((update) => {
       // Only apply updates to entities that currently exist

packages/toolkit/src/immutableStateInvariantMiddleware.ts

@@ -35,8 +35,8 @@ function trackProperties(
   isImmutable: IsImmutableFunc,
   ignorePaths: IgnorePaths = [],
   obj: Record<string, any>,
-  path: string = '',
-  checkedObjects: Set<Record<string, any>> = new Set(),
+  path = '',
+  checkedObjects = new Set<Record<string, any>>(),
 ) {
   const tracked: Partial<TrackedProperty> = { value: obj }
 
@@ -66,8 +66,8 @@ function detectMutations(
   ignoredPaths: IgnorePaths = [],
   trackedProperty: TrackedProperty,
   obj: any,
-  sameParentRef: boolean = false,
-  path: string = '',
+  sameParentRef = false,
+  path = '',
 ): { wasMutated: boolean; path?: string } {
   const prevObj = trackedProperty ? trackedProperty.value : undefined
 

packages/toolkit/src/query/core/apiState.ts

@@ -3,7 +3,9 @@ import type { BaseQueryError } from '../baseQueryTypes'
 import type {
   BaseEndpointDefinition,
   EndpointDefinitions,
+  InfiniteQueryDefinition,
   MutationDefinition,
+  PageParamFrom,
   QueryArgFrom,
   QueryDefinition,
   ResultTypeFrom,
@@ -30,9 +32,9 @@ export type RefetchConfigOptions = {
 
 export type PageParamFunction<DataType, PageParam> = (
   firstPage: DataType,
-  allPages: Array<DataType>,
+  allPages: DataType[],
   firstPageParam: PageParam,
-  allPageParams: Array<PageParam>,
+  allPageParams: PageParam[],
 ) => PageParam | undefined | null
 
 export type InfiniteQueryConfigOptions<DataType, PageParam> = {
@@ -59,8 +61,8 @@ export type InfiniteQueryConfigOptions<DataType, PageParam> = {
 }
 
 export interface InfiniteData<DataType, PageParam> {
-  pages: Array<DataType>
-  pageParams: Array<PageParam>
+  pages: DataType[]
+  pageParams: PageParam[]
 }
 
 /**
@@ -146,7 +148,7 @@ export type SubscriptionOptions = {
    */
   refetchOnFocus?: boolean
 }
-export type Subscribers = { [requestId: string]: SubscriptionOptions }
+export type Subscribers = Record<string, SubscriptionOptions>
 export type QueryKeys<Definitions extends EndpointDefinitions> = {
   [K in keyof Definitions]: Definitions[K] extends QueryDefinition<
     any,
@@ -306,23 +308,20 @@ export type CombinedState<
   config: ConfigState<ReducerPath>
 }
 
-export type InvalidationState<TagTypes extends string> = {
-  [_ in TagTypes]: {
-    [id: string]: Array<QueryCacheKey>
-    [id: number]: Array<QueryCacheKey>
+export type InvalidationState<TagTypes extends string> = Record<
+  TagTypes,
+  {
+    [id: string]: QueryCacheKey[]
+    [id: number]: QueryCacheKey[]
   }
-}
+>
 
-export type QueryState<D extends EndpointDefinitions> = {
-  [queryCacheKey: string]:
-    | QuerySubState<D[string]>
-    | InfiniteQuerySubState<D[string]>
-    | undefined
-}
+export type QueryState<D extends EndpointDefinitions> = Record<
+  string,
+  QuerySubState<D[string]> | InfiniteQuerySubState<D[string]> | undefined
+>
 
-export type SubscriptionState = {
-  [queryCacheKey: string]: Subscribers | undefined
-}
+export type SubscriptionState = Record<string, Subscribers | undefined>
 
 export type ConfigState<ReducerPath> = RefetchConfigOptions & {
   reducerPath: ReducerPath
@@ -336,9 +335,10 @@ export type ModifiableConfigState = {
   invalidationBehavior: 'delayed' | 'immediately'
 } & RefetchConfigOptions
 
-export type MutationState<D extends EndpointDefinitions> = {
-  [requestId: string]: MutationSubState<D[string]> | undefined
-}
+export type MutationState<D extends EndpointDefinitions> = Record<
+  string,
+  MutationSubState<D[string]> | undefined
+>
 
 export type RootState<
   Definitions extends EndpointDefinitions,

packages/toolkit/src/query/core/buildInitiate.ts

@@ -272,19 +272,19 @@ export function buildInitiate({
   api: Api<any, EndpointDefinitions, any, any>
   context: ApiContext<EndpointDefinitions>
 }) {
-  const runningQueries: Map<
+  const runningQueries = new Map<
     Dispatch,
     Record<
       string,
       | QueryActionCreatorResult<any>
       | InfiniteQueryActionCreatorResult<any>
       | undefined
     >
-  > = new Map()
-  const runningMutations: Map<
+  >()
+  const runningMutations = new Map<
     Dispatch,
     Record<string, MutationActionCreatorResult<any> | undefined>
-  > = new Map()
+  >()
 
   const {
     unsubscribeQueryResult,

packages/toolkit/src/query/core/buildThunks.ts

@@ -370,12 +370,12 @@ export function buildThunks<
       )
     }
 
-  function addToStart<T>(items: Array<T>, item: T, max = 0): Array<T> {
+  function addToStart<T>(items: T[], item: T, max = 0): T[] {
     const newItems = [item, ...items]
     return max && newItems.length > max ? newItems.slice(0, -1) : newItems
   }
 
-  function addToEnd<T>(items: Array<T>, item: T, max = 0): Array<T> {
+  function addToEnd<T>(items: T[], item: T, max = 0): T[] {
     const newItems = [...items, item]
     return max && newItems.length > max ? newItems.slice(1) : newItems
   }
@@ -488,7 +488,7 @@ export function buildThunks<
     const endpointDefinition = endpointDefinitions[arg.endpointName]
 
     try {
-      let transformResponse: TransformCallback =
+      const transformResponse: TransformCallback =
         getTransformCallbackForEndpoint(endpointDefinition, 'transformResponse')
 
       const baseQueryApi = {
@@ -707,7 +707,7 @@ export function buildThunks<
     } catch (error) {
       let catchedError = error
       if (catchedError instanceof HandledError) {
-        let transformErrorResponse: TransformCallback =
+        const transformErrorResponse: TransformCallback =
           getTransformCallbackForEndpoint(
             endpointDefinition,
             'transformErrorResponse',
@@ -869,7 +869,7 @@ In the case of an unhandled error, no tags will be "provided" or "invalidated".`
       const force = hasTheForce(options) && options.force
       const maxAge = hasMaxAge(options) && options.ifOlderThan
 
-      const queryAction = (force: boolean = true) => {
+      const queryAction = (force = true) => {
         const options = { forceRefetch: force, isPrefetch: true }
         return (
           api.endpoints[endpointName] as ApiEndpointQuery<any, any>