internalSubscriptions and autobatch

[denbezrukov]

Hi Team.
Thank you for your work.

I was wondering if it might be a problem if subscriptionsUpdated make autobatch

redux-toolkit/packages/toolkit/src/query/core/buildSlice.ts

Lines 426 to 434 in 23a78ca

	const internalSubscriptionsSlice = createSlice({
	name: `${reducerPath}/internalSubscriptions`,
	initialState: initialState as SubscriptionState,
	reducers: {
	subscriptionsUpdated(state, action: PayloadAction<Patch[]>) {
	return applyPatches(state, action.payload)
	},
	},
	})

export const autobatchMiddleware =
  () =>
  () =>
  (next: (action: PayloadAction<unknown>) => PayloadAction<unknown>) =>
  (action: PayloadAction<unknown, string, {[SHOULD_AUTOBATCH]?: boolean}>) => {
    if (action.type.includes('internalSubscriptions/subscriptionsUpdated')) {
      action.meta ??= {}
      action.meta[SHOULD_AUTOBATCH] = true
    }

    return next(action)
  }

[phryneas]

Generally that should not cause any problems. This slice is only there for the Devtools to pick it up; it doesn't have a meaning for any runtime code. Why do you think so?

[phryneas]

Also, even when autobatching, store updates happen immediately, only the notificiation for an UI update is batched.

[denbezrukov]

Thank you for your answer!
I've just discovered that my application has a performance issue with this action and marking it autobatch solves the problem.
I was concerned that it could break the internal code.

[phryneas]

@markerikson did we really miss marking that action? 😅

[phryneas]

Makes sense! It's completely harmless to mark that one :)