From 821be20cebbe2006ec4ee3e5db462ad9b5ad113d Mon Sep 17 00:00:00 2001 From: Mark Erikson Date: Mon, 1 Sep 2025 13:17:45 -0400 Subject: [PATCH 1/3] Add TS 5.9 to the matrix --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 46f9d3475b..16e5c10454 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -305,7 +305,7 @@ jobs: fail-fast: false matrix: node: ['22.x'] - ts: ['5.3', '5.4', '5.5', '5.6', '5.7', '5.8', 'next'] + ts: ['5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9', 'next'] example: [ { name: 'bundler', moduleResolution: 'Bundler' }, From 38537c35d57aaf85317052439c7d82701b715fbf Mon Sep 17 00:00:00 2001 From: Mark Erikson Date: Mon, 1 Sep 2025 13:18:04 -0400 Subject: [PATCH 2/3] Don't run Node10 checks for TS 6+ --- .github/workflows/tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 16e5c10454..8558ad9a43 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -340,10 +340,11 @@ jobs: run: yarn workspace @examples-type-portability/${{ matrix.example.name }} run test - name: Test type portability with `moduleResolution Node10` + if: matrix.ts != 'next' && !startsWith(matrix.ts, '6.') run: yarn workspace @examples-type-portability/${{ matrix.example.name }} run test --module CommonJS --moduleResolution Node10 --preserveSymLinks --verbatimModuleSyntax false - name: Test type portability with `moduleResolution Node10` and `type module` in `package.json` - if: matrix.example.name == 'nodenext-esm' || matrix.example.name == 'bundler' + if: (matrix.example.name == 'nodenext-esm' || matrix.example.name == 'bundler') && matrix.ts != 'next' && !startsWith(matrix.ts, '6.') run: | npm --workspace=@examples-type-portability/${{ matrix.example.name }} pkg set type=module yarn workspace @examples-type-portability/${{ matrix.example.name }} run test --module ESNext --moduleResolution Node10 --preserveSymLinks --verbatimModuleSyntax false From c37b977d15b7465c63805f461c1a61fe9b763e04 Mon Sep 17 00:00:00 2001 From: Mark Erikson Date: Mon, 1 Sep 2025 13:18:11 -0400 Subject: [PATCH 3/3] Add missing error value --- errors.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/errors.json b/errors.json index 8169973800..984b6dd650 100644 --- a/errors.json +++ b/errors.json @@ -41,5 +41,6 @@ "39": "called \\`injectEndpoints\\` to override already-existing endpointName without specifying \\`overrideExisting: true\\`", "40": "maxPages for endpoint '' must be a number greater than 0", "41": "getPreviousPageParam for endpoint '' must be a function if maxPages is used", - "42": "Duplicate middleware references found when creating the store. Ensure that each middleware is only included once." + "42": "Duplicate middleware references found when creating the store. Ensure that each middleware is only included once.", + "43": "`builder.addAsyncThunk` should only be called before calling `builder.addDefaultCase`" } \ No newline at end of file