Make reselect-codemods a Yarn workspace

Author: aryaemami59

.github/workflows/test-reselect-codemods.yml

@@ -25,7 +25,6 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
-          cache-dependency-path: ./codemods
           cache: 'yarn'
 
       - name: Check folder contents

codemods/.gitignore

@@ -1,11 +1,11 @@
 # Dependencies
-node_modules
+node_modules/
 
 # Production
-build
+build/
 
 # Generated files
-.docusaurus
+.docusaurus/
 .cache-loader
 
 # Misc
@@ -18,7 +18,7 @@ build
 npm-debug.log*
 yarn-debug.log*
 yarn-error.log*
-.cache
+.cache/
 .yarnrc
 .yarn/*
 !.yarn/patches
@@ -31,9 +31,15 @@ yarn-error.log*
 
 tsconfig.vitest-temp.json
 .eslintcache
+*.tsbuildinfo
 
-.yalc
+.yalc/
 .yalc.lock
-.vscode
-dist
-temp
+.vscode/
+coverage/
+build/
+lib/
+dist/
+temp/
+.tmp/
+.temp/

codemods/bin/cli.mjs

@@ -1,13 +1,29 @@
 import js from '@eslint/js'
-import prettierConfig from 'eslint-config-prettier'
+import vitestPlugin from '@vitest/eslint-plugin'
+import prettierConfig from 'eslint-config-prettier/flat'
+import type { ConfigArray } from 'typescript-eslint'
 import { config, configs, parser } from 'typescript-eslint'
 
-const ESLintConfig = config(
-  { name: 'ignores', ignores: ['**/dist/', '**/__testfixtures__/'] },
-  { name: 'javascript', ...js.configs.recommended },
+const eslintConfig: ConfigArray = config(
+  {
+    name: 'global-ignores',
+    ignores: [
+      '**/dist/',
+      '**/.yalc/',
+      '**/build/',
+      '**/lib/',
+      '**/temp/',
+      '**/.temp/',
+      '**/.tmp/',
+      '**/.yarn/',
+      '**/coverage/',
+      '**/__testfixtures__/',
+    ],
+  },
+  { name: `${js.meta.name}/recommended`, ...js.configs.recommended },
   ...configs.recommended,
   ...configs.stylistic,
-  { name: 'prettier-config', ...prettierConfig },
+  { name: 'vitest/recommended', ...vitestPlugin.configs.recommended },
   {
     name: 'main',
     languageOptions: {
@@ -16,27 +32,58 @@ const ESLintConfig = config(
         projectService: {
           defaultProject: './tsconfig.json',
         },
+        tsconfigRootDir: import.meta.dirname,
         ecmaVersion: 'latest',
       },
     },
     rules: {
-      'no-undef': [0],
       '@typescript-eslint/consistent-type-imports': [
         2,
-        { fixStyle: 'separate-type-imports', disallowTypeAnnotations: false },
+        {
+          prefer: 'type-imports',
+          fixStyle: 'separate-type-imports',
+          disallowTypeAnnotations: true,
+        },
+      ],
+      '@typescript-eslint/consistent-type-exports': [
+        2,
+        { fixMixedExportsWithInlineTypeSpecifier: false },
+      ],
+      '@typescript-eslint/no-explicit-any': [
+        2,
+        { fixToUnknown: false, ignoreRestArgs: false },
       ],
-      '@typescript-eslint/consistent-type-exports': [2],
-      '@typescript-eslint/no-unused-vars': [0],
-      '@typescript-eslint/no-explicit-any': [0],
       '@typescript-eslint/no-empty-object-type': [
         2,
-        { allowInterfaces: 'with-single-extends' },
+        { allowInterfaces: 'never', allowObjectTypes: 'never' },
+      ],
+      '@typescript-eslint/no-restricted-types': [
+        2,
+        {
+          types: {
+            '{}': {
+              message: `
+- If you want to represent an empty object, use \`type EmptyObject = Record<string, never>\`.
+- If you want to represent an object literal, use either \`type AnyObject = Record<string, any>\` or \`object\`.
+- If you want to represent any non-nullish value, use \`type AnyNonNullishValue = NonNullable<unknown>\`.`,
+              suggest: [
+                'AnyNonNullishValue',
+                'EmptyObject',
+                'AnyObject',
+                'object',
+                'Record<string, never>',
+                'Record<string, any>',
+                'NonNullable<unknown>',
+              ],
+            },
+          },
+        },
       ],
       '@typescript-eslint/no-namespace': [
         2,
-        { allowDeclarations: true, allowDefinitionFiles: true },
+        { allowDeclarations: false, allowDefinitionFiles: true },
       ],
-      '@typescript-eslint/ban-ts-comment': [0],
+      '@typescript-eslint/consistent-type-definitions': [2, 'type'],
       'sort-imports': [
         2,
         {
@@ -47,17 +94,76 @@ const ESLintConfig = config(
           allowSeparatedGroups: true,
         },
       ],
+      '@typescript-eslint/unified-signatures': [2],
+      '@typescript-eslint/no-unnecessary-type-parameters': [2],
+      '@typescript-eslint/no-invalid-void-type': [2],
+      '@typescript-eslint/no-confusing-void-expression': [2],
+      '@typescript-eslint/no-duplicate-type-constituents': [2],
+      '@typescript-eslint/require-await': [2],
+      '@typescript-eslint/no-redundant-type-constituents': [2],
+      '@typescript-eslint/no-unnecessary-type-arguments': [2],
+      '@typescript-eslint/no-unnecessary-type-assertion': [2],
+      '@typescript-eslint/prefer-nullish-coalescing': [2],
+      '@typescript-eslint/no-inferrable-types': [2],
+      'object-shorthand': [2],
+
+      'no-undef': [0],
+      '@typescript-eslint/no-unused-vars': [
+        0,
+        {
+          vars: 'all',
+          args: 'after-used',
+          caughtErrors: 'all',
+          ignoreRestSiblings: false,
+          reportUsedIgnorePattern: false,
+        },
+      ],
+      '@typescript-eslint/ban-ts-comment': [
+        0,
+        [
+          {
+            'ts-expect-error': 'allow-with-description',
+            'ts-ignore': true,
+            'ts-nocheck': true,
+            'ts-check': false,
+            minimumDescriptionLength: 3,
+          },
+        ],
+      ],
+      'vitest/valid-title': [0],
+      'vitest/no-alias-methods': [2],
+      'vitest/no-disabled-tests': [2],
+      'vitest/no-focused-tests': [2],
+      'vitest/no-test-prefixes': [2],
+      'vitest/no-test-return-statement': [2],
+      'vitest/prefer-each': [2],
+      'vitest/prefer-spy-on': [2],
+      'vitest/prefer-to-be': [2],
+      'vitest/prefer-to-contain': [2],
+      'vitest/prefer-to-have-length': [2],
     },
+
+    settings: {
+      vitest: {
+        typecheck: true,
+      },
+    },
+
     linterOptions: { reportUnusedDisableDirectives: 2 },
   },
   {
     name: 'commonjs',
     files: ['**/*.c[jt]s'],
     languageOptions: { sourceType: 'commonjs' },
     rules: {
-      '@typescript-eslint/no-require-imports': [0],
+      '@typescript-eslint/no-require-imports': [
+        0,
+        [{ allow: [], allowAsImport: false }],
+      ],
     },
   },
+
+  prettierConfig,
 )
 
-export default ESLintConfig
+export default eslintConfig