Started adding tests and improving testability of GraphDataGenerator

Author: jimbethancourt

graph-data-generator/src/main/java/org/hjug/gdg/GraphDataGenerator.java

@@ -8,9 +8,13 @@
 
 public class GraphDataGenerator {
 
-    private final CostBenefitCalculator costBenefitCalculator = new CostBenefitCalculator();
+    private final CostBenefitCalculator costBenefitCalculator;
     private final List<RankedDisharmony> calculateCostBenefitValues = new ArrayList<>();
 
+    public GraphDataGenerator(CostBenefitCalculator costBenefitCalculator) {
+        this.costBenefitCalculator = costBenefitCalculator;
+    }
+
     public String getScriptStart() {
         return
                 "      google.charts.load('current', {'packages':['corechart']});\n" +
@@ -39,9 +43,7 @@ public String getScriptEnd() {
                 "    }\n";
     }
 
-    public String generateBubbleChartData(String repositoryPath) {
-
-        List<RankedDisharmony> rankedDisharmonies = getRankedDisharmonies(repositoryPath);
+    public String generateBubbleChartData(List<RankedDisharmony> rankedDisharmonies) {
 
         StringBuilder chartData = new StringBuilder();
         chartData.append("[ 'ID', 'Effort', 'Change Proneness', 'Priority', 'Method Count'], ");

graph-data-generator/src/test/java/org/hjug/gdg/GraphDataGeneratorTest.java

@@ -0,0 +1,61 @@
+package org.hjug.gdg;
+
+import org.hjug.cbc.CostBenefitCalculator;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.*;
+import static org.mockito.Mockito.mock;
+
+public class GraphDataGeneratorTest {
+
+    private GraphDataGenerator graphDataGenerator;
+    private CostBenefitCalculator costBenefitCalculator = mock(CostBenefitCalculator.class);
+
+    @Before
+    public void setUp() {
+        graphDataGenerator = new GraphDataGenerator(costBenefitCalculator);
+    }
+
+    @Test
+    public void getScriptStart() {
+        String scriptStart =
+                        "      google.charts.load('current', {'packages':['corechart']});\n" +
+                        "      google.charts.setOnLoadCallback(drawSeriesChart);\n" +
+                        "\n" +
+                        "    function drawSeriesChart() {\n" +
+                        "\n" +
+                        "      var data = google.visualization.arrayToDataTable([";
+        assertEquals(scriptStart, graphDataGenerator.getScriptStart());
+    }
+
+    @Test
+    public void getScriptEnd() {
+        String scriptEnd =
+                        "]);\n" +
+                        "\n" +
+                        "      var options = {\n" +
+                        "        title: 'Priority Ranking for Refactoring God Classes - ' +\n" +
+                        "               'Fix Higher Priority Classes First',\n" +
+                        "        height: 900, " +
+                        "        width: 1200, " +
+                        "        hAxis: {title: 'Effort'},\n" +
+                        "        vAxis: {title: 'Change Proneness'},\n" +
+                        "        colorAxis: {colors: ['blue', 'green']},\n" +
+                        "        bubble: {textStyle: {fontSize: 11}}      };\n" +
+                        "\n" +
+                        "      var chart = new google.visualization.BubbleChart(document.getElementById('series_chart_div'));\n" +
+                        "      chart.draw(data, options);\n" +
+                        "    }\n";
+
+        assertEquals(scriptEnd, graphDataGenerator.getScriptEnd());
+    }
+
+    @Test
+    public void generateBubbleChartData() {
+    }
+
+    @Test
+    public void getRankedDisharmonies() {
+    }
+}

refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstMavenReport.java

@@ -11,6 +11,7 @@
 import org.apache.maven.plugins.annotations.ResolutionScope;
 import org.apache.maven.reporting.AbstractMavenReport;
 import org.apache.maven.reporting.MavenReportException;
+import org.hjug.cbc.CostBenefitCalculator;
 import org.hjug.cbc.RankedDisharmony;
 import org.hjug.gdg.GraphDataGenerator;
 import org.hjug.git.GitLogReader;
@@ -100,8 +101,8 @@ protected void executeReport(Locale locale) throws MavenReportException {
             return;
         }
 
-        GraphDataGenerator graphDataGenerator = new GraphDataGenerator();
-
+        CostBenefitCalculator costBenefitCalculator = new CostBenefitCalculator();
+        GraphDataGenerator graphDataGenerator = new GraphDataGenerator(costBenefitCalculator);
 
         List<RankedDisharmony> rankedDisharmonies =
                 graphDataGenerator.getRankedDisharmonies(projectBaseDir);
@@ -130,7 +131,7 @@ protected void executeReport(Locale locale) throws MavenReportException {
         mainSink.text("Refactor First Report for " + projectName + " " + projectVersion);
         mainSink.title_();
 
-        generateChart(graphDataGenerator, mainSink);
+        generateChart(graphDataGenerator, rankedDisharmonies, mainSink);
 
         mainSink.head_();
 
@@ -235,7 +236,7 @@ private void drawTableCell(String cellText, Sink mainSink) {
     /**
      * @See https://maven.apache.org/doxia/developers/sink.html#How_to_inject_javascript_code_into_HTML
      */
-    private void generateChart(GraphDataGenerator graphDataGenerator, Sink mainSink) {
+    private void generateChart(GraphDataGenerator graphDataGenerator, List<RankedDisharmony> rankedDisharmonies, Sink mainSink) {
 
         SinkEventAttributeSet googleChartImport = new SinkEventAttributeSet();
         googleChartImport.addAttribute( SinkEventAttributes.TYPE, "text/javascript" );
@@ -245,7 +246,7 @@ private void generateChart(GraphDataGenerator graphDataGenerator, Sink mainSink)
         mainSink.unknown(script, new Object[]{HtmlMarkup.TAG_TYPE_START}, googleChartImport);
         mainSink.unknown(script, new Object[]{HtmlMarkup.TAG_TYPE_END}, null);
         String scriptStart = graphDataGenerator.getScriptStart();
-        String bubbleChartData = graphDataGenerator.generateBubbleChartData(project.getBasedir().getPath());
+        String bubbleChartData = graphDataGenerator.generateBubbleChartData(rankedDisharmonies);
         String scriptEnd = graphDataGenerator.getScriptEnd();
 
         String javascriptCode = scriptStart + bubbleChartData + scriptEnd;