Skip to content

Commit 269573a

Browse files
chriswiningerchriswininger
committed
fix tabs
1 parent 3e1dd60 commit 269573a

File tree

4 files changed

+100
-89
lines changed

4 files changed

+100
-89
lines changed

‎refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstJsonReport/JsonReport.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
@Data
99
@Builder
1010
class JsonReport {
11-
private List<JsonReportDisharmonyEntry> rankedDisharmonies;
12-
private List<String> errors;
11+
private List<JsonReportDisharmonyEntry> rankedDisharmonies;
12+
13+
private List<String> errors;
1314
}

‎refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstJsonReport/JsonReportDisharmonyEntry.java‎

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,28 +12,34 @@
1212
@Data
1313
@Builder
1414
class JsonReportDisharmonyEntry {
15-
private static final DateTimeFormatter formatter =
16-
DateTimeFormatter.ofLocalizedDateTime( FormatStyle.SHORT )
17-
.withLocale( Locale.getDefault() )
18-
.withZone( ZoneId.systemDefault() );
19-
20-
private final String className;
21-
private final Integer effortRank;
22-
private final Integer changePronenessRank;
23-
private final Integer priority;
24-
private final Integer weightedMethodCount;
25-
private final Integer commitCount;
26-
private final String mostRecentCommitTime;
27-
28-
public static JsonReportDisharmonyEntry fromRankedDisharmony(RankedDisharmony entry) {
29-
return JsonReportDisharmonyEntry.builder()
30-
.className(entry.getClassName())
31-
.effortRank(entry.getEffortRank())
32-
.changePronenessRank(entry.getChangePronenessRank())
33-
.priority(entry.getPriority())
34-
.weightedMethodCount(entry.getWmc())
35-
.commitCount(entry.getCommitCount())
36-
.mostRecentCommitTime(formatter.format(entry.getMostRecentCommitTime()))
37-
.build();
38-
}
15+
private static final DateTimeFormatter formatter =
16+
DateTimeFormatter.ofLocalizedDateTime(FormatStyle.SHORT)
17+
.withLocale(Locale.getDefault())
18+
.withZone(ZoneId.systemDefault());
19+
20+
private final String className;
21+
22+
private final Integer effortRank;
23+
24+
private final Integer changePronenessRank;
25+
26+
private final Integer priority;
27+
28+
private final Integer weightedMethodCount;
29+
30+
private final Integer commitCount;
31+
32+
private final String mostRecentCommitTime;
33+
34+
public static JsonReportDisharmonyEntry fromRankedDisharmony(RankedDisharmony entry) {
35+
return JsonReportDisharmonyEntry.builder()
36+
.className(entry.getClassName())
37+
.effortRank(entry.getEffortRank())
38+
.changePronenessRank(entry.getChangePronenessRank())
39+
.priority(entry.getPriority())
40+
.weightedMethodCount(entry.getWmc())
41+
.commitCount(entry.getCommitCount())
42+
.mostRecentCommitTime(formatter.format(entry.getMostRecentCommitTime()))
43+
.build();
44+
}
3945
}

‎refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstJsonReport/RefactorFirstMavenJsonReport.java‎

Lines changed: 36 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -29,50 +29,52 @@
2929
inheritByDefault = false
3030
)
3131
public class RefactorFirstMavenJsonReport extends AbstractMojo {
32-
private static final String FILE_NAME = "refactor-first-data.json";
32+
private static final String FILE_NAME = "refactor-first-data.json";
3333

34-
private static final ObjectMapper MAPPER = new ObjectMapper();
34+
private static final ObjectMapper MAPPER = new ObjectMapper();
3535

36-
@Parameter(readonly = true, defaultValue = "${project}")
37-
private MavenProject project;
36+
@Parameter(readonly = true, defaultValue = "${project}")
37+
private MavenProject project;
3838

39-
@Override
40-
public void execute() {
41-
final String projectBaseDir = project.getBasedir().getPath();
39+
@Override
40+
public void execute() {
41+
final String projectBaseDir = project.getBasedir().getPath();
4242

43-
final CostBenefitCalculator costBenefitCalculator = new CostBenefitCalculator();
44-
final List<RankedDisharmony> rankedDisharmonies = costBenefitCalculator.calculateCostBenefitValues(projectBaseDir);
45-
final List<JsonReportDisharmonyEntry> disharmonyEntries = rankedDisharmonies.stream()
46-
.map(JsonReportDisharmonyEntry::fromRankedDisharmony)
47-
.collect(Collectors.toList());
43+
final CostBenefitCalculator costBenefitCalculator = new CostBenefitCalculator();
44+
final List<RankedDisharmony> rankedDisharmonies =
45+
costBenefitCalculator.calculateCostBenefitValues(projectBaseDir);
46+
final List<JsonReportDisharmonyEntry> disharmonyEntries = rankedDisharmonies.stream()
47+
.map(JsonReportDisharmonyEntry::fromRankedDisharmony)
48+
.collect(Collectors.toList());
4849

49-
final JsonReport report = JsonReport
50-
.builder()
51-
.rankedDisharmonies(disharmonyEntries)
52-
.build();
50+
final JsonReport report = JsonReport
51+
.builder()
52+
.rankedDisharmonies(disharmonyEntries)
53+
.build();
5354

54-
try {
55-
final String reportJson = MAPPER.writeValueAsString(report);
55+
try {
56+
final String reportJson = MAPPER.writeValueAsString(report);
5657

57-
writeReportToDisk(project, FILE_NAME, new StringBuilder(reportJson));
58-
} catch (final JsonProcessingException jsonProcessingException) {
59-
final String errorMessage = "Could not generate a json report: " + jsonProcessingException;
58+
writeReportToDisk(project, FILE_NAME, new StringBuilder(reportJson));
59+
}
60+
catch (final JsonProcessingException jsonProcessingException) {
61+
final String errorMessage = "Could not generate a json report: " + jsonProcessingException;
6062

61-
log.error(errorMessage);
62-
final JsonReport errorReport = JsonReport.builder()
63-
.errors(new ArrayList<>(Collections.singletonList(errorMessage)))
64-
.build();
63+
log.error(errorMessage);
64+
final JsonReport errorReport = JsonReport.builder()
65+
.errors(new ArrayList<>(Collections.singletonList(errorMessage)))
66+
.build();
6567

66-
writeErrorReport(errorReport);
68+
writeErrorReport(errorReport);
69+
}
6770
}
68-
}
6971

70-
private void writeErrorReport(final JsonReport errorReport) {
71-
try {
72-
writeReportToDisk(project, FILE_NAME, new StringBuilder(MAPPER.writeValueAsString(errorReport)));
73-
} catch (final JsonProcessingException jsonProcessingException) {
74-
log.error("failed to write error report: ", jsonProcessingException);
72+
private void writeErrorReport(final JsonReport errorReport) {
73+
try {
74+
writeReportToDisk(project, FILE_NAME, new StringBuilder(MAPPER.writeValueAsString(errorReport)));
75+
}
76+
catch (final JsonProcessingException jsonProcessingException) {
77+
log.error("failed to write error report: ", jsonProcessingException);
78+
}
7579
}
76-
77-
}
7880
}

‎refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/ReportWriter.java‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -11,34 +11,36 @@
1111

1212
@Slf4j
1313
public class ReportWriter {
14-
public static void writeReportToDisk(
15-
final MavenProject project,
16-
final String filename,
17-
final StringBuilder stringBuilder
18-
) {
19-
final String reportOutputDirectory = project.getModel().getReporting().getOutputDirectory();
20-
final File reportOutputDir = new File(reportOutputDirectory);
21-
22-
if(!reportOutputDir.exists()) {
23-
reportOutputDir.mkdirs();
14+
public static void writeReportToDisk(
15+
final MavenProject project,
16+
final String filename,
17+
final StringBuilder stringBuilder
18+
) {
19+
final String reportOutputDirectory = project.getModel().getReporting().getOutputDirectory();
20+
final File reportOutputDir = new File(reportOutputDirectory);
21+
22+
if (!reportOutputDir.exists()) {
23+
reportOutputDir.mkdirs();
24+
}
25+
26+
final String pathname = reportOutputDirectory + File.separator + filename;
27+
28+
final File reportFile = new File(pathname);
29+
30+
try {
31+
reportFile.createNewFile();
32+
}
33+
catch (IOException e) {
34+
log.error("Failure creating chart script file", e);
35+
}
36+
37+
try (BufferedWriter writer = Files.newBufferedWriter(reportFile.toPath(), Charset.defaultCharset())) {
38+
writer.write(stringBuilder.toString());
39+
}
40+
catch (IOException e) {
41+
log.error("Error writing chart script file", e);
42+
}
43+
44+
log.info("Done! View the report at target/site/{}", filename);
2445
}
25-
26-
final String pathname = reportOutputDirectory + File.separator + filename;
27-
28-
final File reportFile = new File(pathname);
29-
30-
try {
31-
reportFile.createNewFile();
32-
} catch (IOException e) {
33-
log.error("Failure creating chart script file", e);
34-
}
35-
36-
try(BufferedWriter writer = Files.newBufferedWriter(reportFile.toPath(), Charset.defaultCharset())) {
37-
writer.write(stringBuilder.toString());
38-
} catch (IOException e) {
39-
log.error("Error writing chart script file", e);
40-
}
41-
42-
log.info("Done! View the report at target/site/{}", filename);
43-
}
4446
}

0 commit comments

Comments
 (0)