Modified the Maven plugin to allow scanning of projects which lack a root-level POM file.

RefactorFirstMavenReport
- Set requiresProject parameter to false. A true value will result in MissingProjectException being thrown if no root-level POM file is present. A falsy value is required to enable scanning of projects without a root-level POM file.
- Added check (starting line 133) for default project name & substitution. The MavenProject dependency will use a default project name of "Maven Sub Project (No POM)" if a root-level POM file is not present. If that name is detected, replace it with the name of the project's root directory.
- Added handling (starting line 202) for an upstream bug in MavenProject dependency. This class's getBasedir method returns null instead of a File instance if no POM file is present in the proejct's root dir. This, in turn, was causing a chained getPath call to fail. Added a check to see if a getBasedir call returns null, and set projectBasedir conditionally.

RefactorFirstMavenCsvReport
- Set requiresProject parameter to false.
- Added check (starting line 79) for default project name & substitutio.
- Added handling (starting line 89) for an upstream bug in MavenProject dependency.

ReportWriter
- In the absence of a root-level POM file, the MavenProject class was returning "${project.basedir}/target/site" as the output directory. Added call to replace to scrub the output directory of the default.

RefactorFirstMavenJsonReport
- Added handling (starting line 41) for an upstream bug in MavenProject dependency.

Tested these changes in the following scenarios, all of which produce expected/correct behaviour:
- projects containing a root-level POM file
- projects lacking any POM files
- projects without a root-level POM, but containing sub-projects which DO have their own POM files

Author: Michael MacKinnon

refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstJsonReport/RefactorFirstMavenJsonReport.java

@@ -4,6 +4,8 @@
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import java.io.File;
+import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -36,7 +38,14 @@ public class RefactorFirstMavenJsonReport extends AbstractMojo {
 
     @Override
     public void execute() {
-        final String projectBaseDir = project.getBasedir().getPath();
+        String projectBaseDir;
+
+        File baseDir = project.getBasedir();
+        if (baseDir != null) {
+            projectBaseDir = baseDir.getPath();
+        } else {
+            projectBaseDir = Paths.get("").toAbsolutePath().toString();
+        }
 
         final CostBenefitCalculator costBenefitCalculator = new CostBenefitCalculator();
         final List<RankedDisharmony> rankedDisharmonies =

refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstMavenCsvReport.java

@@ -3,13 +3,11 @@
 import static org.hjug.mavenreport.ReportWriter.writeReportToDisk;
 
 import java.io.File;
+import java.nio.file.Paths;
 import java.time.Instant;
 import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
-import java.util.Comparator;
-import java.util.List;
-import java.util.Locale;
-import java.util.Optional;
+import java.util.*;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugins.annotations.LifecyclePhase;
@@ -26,7 +24,7 @@
         name = "csvreport",
         defaultPhase = LifecyclePhase.SITE,
         requiresDependencyResolution = ResolutionScope.RUNTIME,
-        requiresProject = true,
+        requiresProject = false,
         threadSafe = true,
         inheritByDefault = false)
 public class RefactorFirstMavenCsvReport extends AbstractMojo {
@@ -78,16 +76,30 @@ public void execute() {
                 .append(".csv");
         String filename = fileNameSB.toString();
 
+        if (Objects.equals(project.getName(), "Maven Stub Project (No POM)")) {
+            projectName = new File(Paths.get("").toAbsolutePath().toString()).getName();
+        }
+
         log.info("Generating {} for {} - {} date: {}", filename, projectName, projectVersion, publishedDate);
 
         StringBuilder contentBuilder = new StringBuilder();
 
         // git management
         GitLogReader gitLogReader = new GitLogReader();
-        String projectBaseDir = project.getBasedir().getPath();
-        Optional<File> optionalGitDir = Optional.ofNullable(gitLogReader.getGitDir(project.getBasedir()));
-        File gitDir;
+        String projectBaseDir;
+        Optional<File> optionalGitDir;
 
+        File baseDir = project.getBasedir();
+        if (baseDir != null) {
+            projectBaseDir = baseDir.getPath();
+            optionalGitDir = Optional.ofNullable(gitLogReader.getGitDir(baseDir));
+        } else {
+            // TODO: ensure File is initialized to the project root directory, not PWD
+            projectBaseDir = Paths.get("").toAbsolutePath().toString();
+            optionalGitDir = Optional.ofNullable(gitLogReader.getGitDir(new File(projectBaseDir)));
+        }
+
+        File gitDir;
         if (optionalGitDir.isPresent()) {
             gitDir = optionalGitDir.get();
         } else {

refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/RefactorFirstMavenReport.java

@@ -6,14 +6,12 @@
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
+import java.nio.file.Paths;
 import java.time.Instant;
 import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
 import java.time.format.FormatStyle;
-import java.util.Comparator;
-import java.util.List;
-import java.util.Locale;
-import java.util.Optional;
+import java.util.*;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugins.annotations.LifecyclePhase;
@@ -31,7 +29,7 @@
         name = "report",
         defaultPhase = LifecyclePhase.SITE,
         requiresDependencyResolution = ResolutionScope.RUNTIME,
-        requiresProject = true,
+        requiresProject = false,
         threadSafe = true,
         inheritByDefault = false)
 public class RefactorFirstMavenReport extends AbstractMojo {
@@ -132,6 +130,10 @@ public void execute() {
 
         String filename = getOutputName() + ".html";
 
+        if (Objects.equals(project.getName(), "Maven Stub Project (No POM)")) {
+            projectName = new File(Paths.get("").toAbsolutePath().toString()).getName();
+        }
+
         log.info("Generating {} for {} - {}", filename, projectName, projectVersion);
 
         DateTimeFormatter formatter = DateTimeFormatter.ofLocalizedDateTime(FormatStyle.SHORT)
@@ -197,10 +199,19 @@ public void execute() {
                 .append("<div id=\"series_chart_div\"></div>");
 
         GitLogReader gitLogReader = new GitLogReader();
-        String projectBaseDir = project.getBasedir().getPath();
-        Optional<File> optionalGitDir = Optional.ofNullable(gitLogReader.getGitDir(project.getBasedir()));
-        File gitDir;
+        String projectBaseDir;
+        Optional<File> optionalGitDir;
 
+        File baseDir = project.getBasedir();
+        if (baseDir != null) {
+            projectBaseDir = baseDir.getPath();
+            optionalGitDir = Optional.ofNullable(gitLogReader.getGitDir(baseDir));
+        } else {
+            projectBaseDir = Paths.get("").toAbsolutePath().toString();
+            optionalGitDir = Optional.ofNullable(gitLogReader.getGitDir(new File(projectBaseDir)));
+        }
+
+        File gitDir;
         if (optionalGitDir.isPresent()) {
             gitDir = optionalGitDir.get();
         } else {

refactor-first-maven-plugin/src/main/java/org/hjug/mavenreport/ReportWriter.java

@@ -12,7 +12,10 @@
 public class ReportWriter {
     public static void writeReportToDisk(
             final MavenProject project, final String filename, final StringBuilder stringBuilder) {
-        final String reportOutputDirectory = project.getModel().getReporting().getOutputDirectory();
+        final String reportOutputDirectory = project.getModel()
+                .getReporting()
+                .getOutputDirectory()
+                .replace("${project.basedir}" + File.separator, "");
         final File reportOutputDir = new File(reportOutputDirectory);
 
         if (!reportOutputDir.exists()) {