Extract God class and Highly Coupled Class rendering into separate methods

Author: jimbethancourt

report/src/main/java/org/hjug/refactorfirst/report/SimpleHtmlReport.java

@@ -174,125 +174,135 @@ public void execute(
         }
 
         if (!rankedGodClassDisharmonies.isEmpty()) {
-            int maxGodClassPriority = rankedGodClassDisharmonies
-                    .get(rankedGodClassDisharmonies.size() - 1)
-                    .getPriority();
+            renderGodClassInfo(showDetails, outputDirectory, rankedGodClassDisharmonies, stringBuilder, godClassTableHeadings, formatter);
+        }
 
-            stringBuilder.append("<div style=\"text-align: center;\"><a id=\"GOD\"><h1>God Classes</h1></a></div>");
+        if (!rankedGodClassDisharmonies.isEmpty() && !rankedCBODisharmonies.isEmpty()) {
+            stringBuilder.append("<br/>\n" + "<br/>\n" + "<br/>\n" + "<br/>\n" + "<hr/>\n" + "<br/>\n" + "<br/>");
+        }
 
-            renderGodClassChart(outputDirectory, rankedGodClassDisharmonies, maxGodClassPriority, stringBuilder);
+        if (!rankedCBODisharmonies.isEmpty()) {
+            renderHighlyCoupledClassInfo(outputDirectory, stringBuilder, rankedCBODisharmonies, formatter);
+        }
 
-            stringBuilder.append(
-                    "<h2 align=\"center\">God classes by the numbers: (Refactor Starting with Priority 1)</h2>");
-            stringBuilder.append("<table align=\"center\" border=\"5px\">");
+        stringBuilder.append("</section>");
+        printProjectFooter(stringBuilder, formatter);
+        stringBuilder.append(THE_END);
 
-            // Content
-            stringBuilder.append("<thead><tr>");
-            for (String heading : godClassTableHeadings) {
-                stringBuilder.append("<th>").append(heading).append("</th>");
-            }
-            stringBuilder.append("</tr></thead>");
-
-            stringBuilder.append("<tbody>");
-            for (RankedDisharmony rankedGodClassDisharmony : rankedGodClassDisharmonies) {
-                stringBuilder.append("<tr>");
-
-                String[] simpleRankedGodClassDisharmonyData = {
-                    rankedGodClassDisharmony.getFileName(),
-                    rankedGodClassDisharmony.getPriority().toString(),
-                    rankedGodClassDisharmony.getChangePronenessRank().toString(),
-                    rankedGodClassDisharmony.getEffortRank().toString(),
-                    rankedGodClassDisharmony.getWmc().toString(),
-                    formatter.format(rankedGodClassDisharmony.getMostRecentCommitTime()),
-                    rankedGodClassDisharmony.getCommitCount().toString()
-                };
-
-                String[] detailedRankedGodClassDisharmonyData = {
-                    rankedGodClassDisharmony.getFileName(),
-                    rankedGodClassDisharmony.getPriority().toString(),
-                    rankedGodClassDisharmony.getRawPriority().toString(),
-                    rankedGodClassDisharmony.getChangePronenessRank().toString(),
-                    rankedGodClassDisharmony.getEffortRank().toString(),
-                    rankedGodClassDisharmony.getWmc().toString(),
-                    rankedGodClassDisharmony.getWmcRank().toString(),
-                    rankedGodClassDisharmony.getAtfd().toString(),
-                    rankedGodClassDisharmony.getAtfdRank().toString(),
-                    rankedGodClassDisharmony.getTcc().toString(),
-                    rankedGodClassDisharmony.getTccRank().toString(),
-                    formatter.format(rankedGodClassDisharmony.getFirstCommitTime()),
-                    formatter.format(rankedGodClassDisharmony.getMostRecentCommitTime()),
-                    rankedGodClassDisharmony.getCommitCount().toString(),
-                    rankedGodClassDisharmony.getPath()
-                };
-
-                final String[] rankedDisharmonyData =
-                        showDetails ? detailedRankedGodClassDisharmonyData : simpleRankedGodClassDisharmonyData;
-
-                for (String rowData : rankedDisharmonyData) {
-                    drawTableCell(rowData, stringBuilder);
-                }
-
-                stringBuilder.append("</tr>");
-            }
+        log.debug(stringBuilder.toString());
+
+        writeReportToDisk(outputDirectory, filename, stringBuilder);
+        log.info("Done! View the report at target/site/{}", filename);
+    }
+
+    private void renderGodClassInfo(boolean showDetails, String outputDirectory, List<RankedDisharmony> rankedGodClassDisharmonies, StringBuilder stringBuilder, String[] godClassTableHeadings, DateTimeFormatter formatter) {
+        int maxGodClassPriority = rankedGodClassDisharmonies
+                .get(rankedGodClassDisharmonies.size() - 1)
+                .getPriority();
+
+        stringBuilder.append("<div style=\"text-align: center;\"><a id=\"GOD\"><h1>God Classes</h1></a></div>");
 
-            stringBuilder.append("</tbody>");
-            stringBuilder.append("</table>");
+        renderGodClassChart(outputDirectory, rankedGodClassDisharmonies, maxGodClassPriority, stringBuilder);
+
+        stringBuilder.append(
+                "<h2 align=\"center\">God classes by the numbers: (Refactor Starting with Priority 1)</h2>");
+        stringBuilder.append("<table align=\"center\" border=\"5px\">");
+
+        // Content
+        stringBuilder.append("<thead><tr>");
+        for (String heading : godClassTableHeadings) {
+            stringBuilder.append("<th>").append(heading).append("</th>");
         }
+        stringBuilder.append("</tr></thead>");
+
+        stringBuilder.append("<tbody>");
+        for (RankedDisharmony rankedGodClassDisharmony : rankedGodClassDisharmonies) {
+            stringBuilder.append("<tr>");
+
+            String[] simpleRankedGodClassDisharmonyData = {
+                rankedGodClassDisharmony.getFileName(),
+                rankedGodClassDisharmony.getPriority().toString(),
+                rankedGodClassDisharmony.getChangePronenessRank().toString(),
+                rankedGodClassDisharmony.getEffortRank().toString(),
+                rankedGodClassDisharmony.getWmc().toString(),
+                formatter.format(rankedGodClassDisharmony.getMostRecentCommitTime()),
+                rankedGodClassDisharmony.getCommitCount().toString()
+            };
+
+            String[] detailedRankedGodClassDisharmonyData = {
+                rankedGodClassDisharmony.getFileName(),
+                rankedGodClassDisharmony.getPriority().toString(),
+                rankedGodClassDisharmony.getRawPriority().toString(),
+                rankedGodClassDisharmony.getChangePronenessRank().toString(),
+                rankedGodClassDisharmony.getEffortRank().toString(),
+                rankedGodClassDisharmony.getWmc().toString(),
+                rankedGodClassDisharmony.getWmcRank().toString(),
+                rankedGodClassDisharmony.getAtfd().toString(),
+                rankedGodClassDisharmony.getAtfdRank().toString(),
+                rankedGodClassDisharmony.getTcc().toString(),
+                rankedGodClassDisharmony.getTccRank().toString(),
+                formatter.format(rankedGodClassDisharmony.getFirstCommitTime()),
+                formatter.format(rankedGodClassDisharmony.getMostRecentCommitTime()),
+                rankedGodClassDisharmony.getCommitCount().toString(),
+                rankedGodClassDisharmony.getPath()
+            };
+
+            final String[] rankedDisharmonyData =
+                    showDetails ? detailedRankedGodClassDisharmonyData : simpleRankedGodClassDisharmonyData;
+
+            for (String rowData : rankedDisharmonyData) {
+                drawTableCell(rowData, stringBuilder);
+            }
 
-        if (!rankedCBODisharmonies.isEmpty()) {
+            stringBuilder.append("</tr>");
+        }
 
-            stringBuilder.append("<br/>\n" + "<br/>\n" + "<br/>\n" + "<br/>\n" + "<hr/>\n" + "<br/>\n" + "<br/>");
+        stringBuilder.append("</tbody>");
+        stringBuilder.append("</table>");
+    }
 
-            stringBuilder.append(
-                    "<div style=\"text-align: center;\"><a id=\"CBO\"><h1>Highly Coupled Classes</h1></a></div>");
+    private void renderHighlyCoupledClassInfo(String outputDirectory, StringBuilder stringBuilder, List<RankedDisharmony> rankedCBODisharmonies, DateTimeFormatter formatter) {
+        stringBuilder.append(
+                "<div style=\"text-align: center;\"><a id=\"CBO\"><h1>Highly Coupled Classes</h1></a></div>");
 
-            int maxCboPriority =
-                    rankedCBODisharmonies.get(rankedCBODisharmonies.size() - 1).getPriority();
+        int maxCboPriority =
+                rankedCBODisharmonies.get(rankedCBODisharmonies.size() - 1).getPriority();
 
-            renderCBOChart(outputDirectory, rankedCBODisharmonies, maxCboPriority, stringBuilder);
+        renderCBOChart(outputDirectory, rankedCBODisharmonies, maxCboPriority, stringBuilder);
 
-            stringBuilder.append(
-                    "<h2 align=\"center\">Highly Coupled classes by the numbers: (Refactor starting with Priority 1)</h2>");
-            stringBuilder.append("<table align=\"center\" border=\"5px\">");
+        stringBuilder.append(
+                "<h2 align=\"center\">Highly Coupled classes by the numbers: (Refactor starting with Priority 1)</h2>");
+        stringBuilder.append("<table align=\"center\" border=\"5px\">");
 
-            // Content
-            stringBuilder.append("<thead><tr>");
-            for (String heading : cboTableHeadings) {
-                stringBuilder.append("<th>").append(heading).append("</th>");
-            }
-            stringBuilder.append("</tr></thead>");
+        // Content
+        stringBuilder.append("<thead><tr>");
+        for (String heading : cboTableHeadings) {
+            stringBuilder.append("<th>").append(heading).append("</th>");
+        }
+        stringBuilder.append("</tr></thead>");
 
-            stringBuilder.append("<tbody>");
-            for (RankedDisharmony rankedCboClassDisharmony : rankedCBODisharmonies) {
-                stringBuilder.append("<tr>");
+        stringBuilder.append("<tbody>");
+        for (RankedDisharmony rankedCboClassDisharmony : rankedCBODisharmonies) {
+            stringBuilder.append("<tr>");
 
-                String[] rankedCboClassDisharmonyData = {
+            String[] rankedCboClassDisharmonyData = {
                     rankedCboClassDisharmony.getFileName(),
                     rankedCboClassDisharmony.getPriority().toString(),
                     rankedCboClassDisharmony.getChangePronenessRank().toString(),
                     rankedCboClassDisharmony.getEffortRank().toString(),
                     formatter.format(rankedCboClassDisharmony.getMostRecentCommitTime()),
                     rankedCboClassDisharmony.getCommitCount().toString()
-                };
+            };
 
-                for (String rowData : rankedCboClassDisharmonyData) {
-                    drawTableCell(rowData, stringBuilder);
-                }
-
-                stringBuilder.append("</tr>");
+            for (String rowData : rankedCboClassDisharmonyData) {
+                drawTableCell(rowData, stringBuilder);
             }
 
-            stringBuilder.append("</tbody>");
+            stringBuilder.append("</tr>");
         }
 
-        stringBuilder.append("</table></section>");
-        printProjectFooter(stringBuilder, formatter);
-        stringBuilder.append(THE_END);
-
-        log.debug(stringBuilder.toString());
-
-        writeReportToDisk(outputDirectory, filename, stringBuilder);
-        log.info("Done! View the report at target/site/{}", filename);
+        stringBuilder.append("</tbody>");
+        stringBuilder.append("</table>");
     }
 
     void drawTableCell(String rowData, StringBuilder stringBuilder) {