Removed RepositoryLogReader

Removed RepositoryLogReader - it was getting in the way more than it was helping

Author: jimbethancourt

change-proneness-ranker/src/main/java/org/hjug/git/ChangePronenessRanker.java

@@ -12,9 +12,9 @@
 public class ChangePronenessRanker {
 
     private Repository repository;
-    private RepositoryLogReader repositoryLogReader;
+    private GitLogReader repositoryLogReader;
 
-    public ChangePronenessRanker(Repository repository, RepositoryLogReader repositoryLogReader) {
+    public ChangePronenessRanker(Repository repository, GitLogReader repositoryLogReader) {
         this.repositoryLogReader = repositoryLogReader;
         this.repository = repository;
     }

change-proneness-ranker/src/main/java/org/hjug/git/GitLogReader.java

@@ -15,15 +15,14 @@
 import org.eclipse.jgit.util.io.NullOutputStream;
 
 @Slf4j
-public class GitLogReader implements RepositoryLogReader {
+public class GitLogReader {
 
     static final String JAVA_FILE_TYPE = ".java";
 
     // Based on
     // https://github.com/Cosium/git-code-format-maven-plugin/blob/master/src/main/java/com/cosium/code/format/AbstractMavenGitCodeFormatMojo.java
     // MIT License
     // Move to a provider?
-    @Override
     public Repository gitRepository(File basedir) throws IOException {
         Repository gitRepository;
         FileRepositoryBuilder repositoryBuilder = new FileRepositoryBuilder().findGitDir(basedir);
@@ -46,7 +45,6 @@ public File getGitDir(File basedir) {
     // https://stackoverflow.com/a/19950970/346247
     // and
     // https://github.com/centic9/jgit-cookbook/blob/master/src/main/java/org/dstadler/jgit/api/ReadFileFromCommit.java
-    @Override
     public Map<String, ByteArrayOutputStream> listRepositoryContentsAtHEAD(Repository repository) throws IOException {
         Ref head = repository.exactRef("HEAD");
         // a RevWalk allows us to walk over commits based on some filtering that is defined
@@ -88,7 +86,6 @@ public Map<String, ByteArrayOutputStream> listRepositoryContentsAtHEAD(Repositor
      * @return a LogInfo object
      * @throws GitAPIException
      */
-    @Override
     public ScmLogInfo fileLog(Repository repository, String path) throws GitAPIException, IOException {
         Git git = new Git(repository);
         ObjectId branchId = repository.resolve("HEAD");
@@ -118,7 +115,6 @@ public ScmLogInfo fileLog(Repository repository, String path) throws GitAPIExcep
     }
 
     // based on https://stackoverflow.com/questions/27361538/how-to-show-changes-between-commits-with-jgit
-    @Override
     public TreeMap<Integer, Integer> captureChangeCountByCommitTimestamp(Repository repository)
             throws IOException, GitAPIException {
 

change-proneness-ranker/src/main/java/org/hjug/git/RepositoryLogReader.java

@@ -14,11 +14,11 @@
 public class ChangePronenessRankerTest {
 
     private ChangePronenessRanker changePronenessRanker;
-    private RepositoryLogReader repositoryLogReader;
+    private GitLogReader repositoryLogReader;
 
     @BeforeEach
     public void setUp() {
-        repositoryLogReader = mock(RepositoryLogReader.class);
+        repositoryLogReader = mock(GitLogReader.class);
         changePronenessRanker = new ChangePronenessRanker(null, repositoryLogReader);
     }
 

change-proneness-ranker/src/test/java/org/hjug/git/ChangePronenessRankerTest.java

@@ -18,7 +18,6 @@
 import org.eclipse.jgit.lib.Repository;
 import org.hjug.git.ChangePronenessRanker;
 import org.hjug.git.GitLogReader;
-import org.hjug.git.RepositoryLogReader;
 import org.hjug.git.ScmLogInfo;
 import org.hjug.metrics.*;
 import org.hjug.metrics.rules.CBORule;
@@ -54,7 +53,7 @@ public void runPmdAnalysis(String projectBaseDir) throws IOException {
 
     public List<RankedDisharmony> calculateGodClassCostBenefitValues(String repositoryPath) {
 
-        RepositoryLogReader repositoryLogReader = new GitLogReader();
+        GitLogReader repositoryLogReader = new GitLogReader();
         Repository repository = null;
         log.info("Initiating Cost Benefit calculation");
         try {
@@ -115,7 +114,7 @@ private List<GodClass> getGodClasses() {
     }
 
     <T extends Disharmony> List<ScmLogInfo> getRankedChangeProneness(
-            RepositoryLogReader repositoryLogReader, Repository repository, List<T> disharmonies) {
+            GitLogReader repositoryLogReader, Repository repository, List<T> disharmonies) {
         List<ScmLogInfo> scmLogInfos = new ArrayList<>();
         log.info("Calculating Change Proneness");
         for (Disharmony disharmony : disharmonies) {
@@ -143,7 +142,7 @@ <T extends Disharmony> List<ScmLogInfo> getRankedChangeProneness(
 
     public List<RankedDisharmony> calculateCBOCostBenefitValues(String repositoryPath) {
 
-        RepositoryLogReader repositoryLogReader = new GitLogReader();
+        GitLogReader repositoryLogReader = new GitLogReader();
         Repository repository = null;
         log.info("Initiating Cost Benefit calculation");
         try {